Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stream template to package json #335

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Apr 9, 2020

The index.json file for a package so far did contain all information about streams but was missing the content of the stream.yml file. This PR adds it to the index.json file to simplify the building of the UI.

With this, the stream.yml becomes a requirement for a dataset. Because of this all missing stream.yml are added / renamed.

The index.json file for a package so far did contain all information about streams but was missing the content of the stream.yml file. This PR adds it to the index.json file to simplify the building of the UI.

With this, the stream.yml becomes a requirement for a dataset. Because of this all missing stream.yml are added / renamed.
@ruflin ruflin requested review from nchaulet and jen-huang April 9, 2020 19:31
@ruflin ruflin self-assigned this Apr 9, 2020
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@ruflin ruflin merged commit 938b098 into elastic:master Apr 14, 2020
@ruflin
Copy link
Contributor Author

ruflin commented Apr 14, 2020

Merged this for now. I might follow up with some more config options around stream.yml as at the moment only 1 is possible, but multiple inputs could use the same dataset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants