Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate handlebars template #445

Merged
merged 2 commits into from
May 11, 2020
Merged

Validate handlebars template #445

merged 2 commits into from
May 11, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented May 8, 2020

Issue: #444

Changes:

  • use github.com/aymerick/raymond (MIT) as template parser
  • fix errors spotted in example package
  • extend validation of stream configuration with parsing handlebars

@mtojek mtojek requested a review from ruflin May 8, 2020 13:41
@mtojek mtojek self-assigned this May 8, 2020
@elasticmachine
Copy link

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

ruflin
ruflin approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Could you add a changelog entry?

@mtojek mtojek merged commit b46109e into elastic:master May 11, 2020
@jen-huang jen-huang mentioned this pull request Jun 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ruflin