Generate package index.json #479
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
|
docs/api/package.json
Outdated
| @@ -34,82 +34,14 @@ | |||
| "type": "image/png" | |||
| } | |||
| ], | |||
| "assets": [ | |||
There was a problem hiding this comment.
What about this missing content here?
There was a problem hiding this comment.
Fixed. I didn't know I have to load assets additionally.
| @@ -63,7 +63,6 @@ func TestEndpoints(t *testing.T) { | |||
| {"/search?internal=bar", "/search", "search-package-internal-error.json", searchHandler(packagesBasePath, testCacheTime)}, | |||
| {"/search?experimental=true", "/search", "search-package-experimental.json", searchHandler(packagesBasePath, testCacheTime)}, | |||
| {"/search?experimental=foo", "/search", "search-package-experimental-error.json", searchHandler(packagesBasePath, testCacheTime)}, | |||
| {"/package/example/1.0.0", "", "package.json", catchAll(http.Dir(publicPath), testCacheTime)}, | |||
There was a problem hiding this comment.
Could we still have a test for this? The API endpoint should still work.
There was a problem hiding this comment.
This test is used in the TestPackageIndex method.
| {"/package/example/1.0.0/index.json", packageIndexRouterPath1, "package.json", packageIndexHandler}, | ||
| {"/package/missing/1.0.0/index.json", packageIndexRouterPath1, "index-package-not-found.txt", packageIndexHandler}, | ||
| {"/package/example/999.0.0/index.json", packageIndexRouterPath1, "index-package-revision-not-found.txt", packageIndexHandler}, | ||
| {"/package/example/a.b.c/index.json", packageIndexRouterPath1, "index-package-invalid-version.txt", packageIndexHandler}, |
There was a problem hiding this comment.
Could we add a test that doesn't have index.json inside, for example /package/example/1.0.0?
| @@ -53,6 +55,11 @@ func ArchivePackage(w io.Writer, properties PackageProperties) (err error) { | |||
|
|
|||
| rootDir := fmt.Sprintf("%s-%s", properties.Name, properties.Version) | |||
|
|
|||
| err = writePackageIndexToArchive(properties.Path, rootDir, tarWriter) | |||
There was a problem hiding this comment.
Could you add a note here that we have this in because Kibana still relies on it but it should potentially be removed in the future?
Issue: #464
@jfsiii API hasn't changed in this PR, but I wish to get rid of
index.jsonfrom inside of a bundle (.tar.gz).