Remove requirement for streams definition in dataset manifest #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously streams definition in the dataset manifest was required. This led to the problem that for example the endpoint package specified an input there even though it is not used: https://github.com/elastic/package-storage/blob/master/packages/endpoint/0.1.0/dataset/events/manifest.yml This removes the requirement for the streams definition and adds a package for testing it.
ruflin
commented
May 27, 2020
|
|
||
|
|
||
| ## [Unreleased](https://github.com/elastic/package-registry/compare/v0.2.0...v0.3.0) |
There was a problem hiding this comment.
Found this issue while updating the changelog.
| @@ -17,6 +17,7 @@ | |||
| 91348 example-0.0.2/kibana/index-pattern/filebeat.json | |||
| 0 example-0.0.2/kibana/infrastructure-ui-source/ | |||
| 797 example-0.0.2/kibana/infrastructure-ui-source/default.json | |||
| 0 example-0.0.2/kibana/search/ | |||
There was a problem hiding this comment.
@mtojek Kind of suprised about this change. Lets see what CI thinks.
There was a problem hiding this comment.
Turns out I had locally still an empty directory probably which is not checked into git. Cleaning up the testdata directory and checking it out again solved this issue (I hope).
💚 Build Succeeded
Expand to view the summary
Build stats
|
mtojek
approved these changes
May 29, 2020
|
@jonathan-buttner Could you try to to update the endpoint package on the above? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously streams definition in the dataset manifest was required. This led to the problem that for example the endpoint package specified an input there even though it is not used: https://github.com/elastic/package-storage/blob/master/packages/endpoint/0.1.0/dataset/events/manifest.yml This removes the requirement for the streams definition and adds a package for testing it.