Update registry for stream.* to dataset.* change #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
|
ph
approved these changes
Jun 3, 2020
This was referenced Jun 4, 2020
Now the dataset intsead of the stream fields are added and validated. Updating also the base package. This will have to be pushed to the package-storage. Part of elastic#491
mtojek
approved these changes
Jun 8, 2020
There was a problem hiding this comment.
Approved, based on the fact that there are changes for integrations ready in elastic/integrations#64
ruflin
pushed a commit
to elastic/kibana
that referenced
this pull request
Jun 9, 2020
Resolves #67672 Part of elastic/package-registry#491 See elastic/package-registry#492 for package registry changes. Updates existing queries to use `dataset.*` fields. from `stream.*` fields. I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Jun 9, 2020
…ic#68322) Resolves elastic#67672 Part of elastic/package-registry#491 See elastic/package-registry#492 for package registry changes. Updates existing queries to use `dataset.*` fields. from `stream.*` fields. I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
jen-huang
added a commit
to elastic/kibana
that referenced
this pull request
Jun 9, 2020
… (#68667) Resolves #67672 Part of elastic/package-registry#491 See elastic/package-registry#492 for package registry changes. Updates existing queries to use `dataset.*` fields. from `stream.*` fields. I looked at the EPM code paths for asset installation, and did not find anything that would need to be changed based on the above package registry changes. We don't hardcode anything specific for field names. The package information (i.e. [nginx package info](https://epr.elastic.co/package/nginx/0.1.2/)) is not affected by the current package registry changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the dataset intsead of the stream fields are added and validated.
Updating also the base package. This will have to be pushed to the package-storage.
Part of #491