Add not found handler to router #652
Conversation
CHANGELOG.md
Outdated
| @@ -21,7 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Breaking changes | |||
|
|
|||
| ### Bugfixes | |||
| * Set cache headers for 404 and 400 to 0. [#649](https://github.com/elastic/package-registry/pull/649) | |||
| * Set cache headers for 404 and 400 to private, no-store. [#649](https://github.com/elastic/package-registry/pull/649)[#652](https://github.com/elastic/package-registry/pull/652) | |||
There was a problem hiding this comment.
hmm we might want to leave this as it was and move the 652 part to unreleased right? Since we technically already released 0.13.0 🤷
There was a problem hiding this comment.
Updated. I kept the correction to the old changelog in as it was not accurate.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
Hey @ruflin, is this PR still relevant? If so, could you rebase and merge it? Thanks! |
So far, the default not found handler was used from mux. To set specific headers, this must be overwritten.
ruflin
force-pushed
the
not-found-handler
branch
from
46392ff
to
7e9b5a0
Compare
|
Rebased. I think it is still relevant. Initially we had to fix an urgent CDN bug which we did. This will improve it further if I remember correctly to not cache 404. |
|
Thanks @ruflin. Going ahead and merging on your behalf. I'd like to cut a new release of the registry today and it would nice to get this one into that. |
|
Thanks! |
So far, the default not found handler was used from mux. To set specific headers, this must be overwritten.