Add hidden field to data stream #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
mtojek
reviewed
Dec 9, 2020
|
@mtojek added the test package, see this comment #657 (comment) |
mtojek
approved these changes
Dec 10, 2020
CHANGELOG.md
Outdated
| @@ -14,7 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|
|||
| * Add "traces" as legal event type. [#656](https://github.com/elastic/package-registry/pull/656) | |||
| * Add input-level `template_path` field. [#655](https://github.com/elastic/package-registry/pull/655) | |||
|
|
|||
| * Add hidden field to data stream. [#660] (https://github.com/elastic/package-registry/pull/660) | |||
There was a problem hiding this comment.
nit: hidden or "hidden"
in this case a hidden field may sound confusing :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: elastic/security-team#548
This PR adds hidden property to data stream. The hidden field allows fleet to mark the data stream as hidden elastic/elasticsearch#63987 . This hidden feature is needed for issue 548 to hide the data stream from views.
hiddenfieldFurther, the hidden field will correspond with this ES change: elastic/elasticsearch#63987 . We want to give the flexibility for package authors to denote a data stream as hidden for purposes such as this where a data stream is not intended for app specific usage and should be hidden to reduce user confusion.
Our specific use case, again, has to do with a data stream that is intended to be queried by a separate telemetry server. As a result, we want the data stream to be hidden to reduce user confusion.