-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "dataset_is_prefix" field to data_stream, if present. #674
Conversation
14e1c8c
to
be4bf15
Compare
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
Hi @skh, could you try running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a CHANGELOG entry for this change, please? Thanks!
https://github.com/elastic/package-registry/blob/master/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would be nice to have a follow up adding this to one of the test packages: https://github.com/elastic/package-registry/tree/master/testdata/package Then we can see how the actual output looks. |
|
This change exposes the new field
dataset_is_prefix
so that it can be used by Kibana/EPM.The field was added to package-spec in elastic/package-spec#102