Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "dataset_is_prefix" field to data_stream, if present. #674

Merged
merged 3 commits into from
Jan 26, 2021

Conversation

skh
Copy link
Contributor

@skh skh commented Jan 26, 2021

This change exposes the new field dataset_is_prefix so that it can be used by Kibana/EPM.

The field was added to package-spec in elastic/package-spec#102

@elasticmachine
Copy link

elasticmachine commented Jan 26, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #674 updated

    • Start Time: 2021-01-26T14:43:00.809+0000
  • Duration: 6 min 55 sec

  • Commit: 679c06c

Test stats 🧪

Test Results
Failed 0
Passed 169
Skipped 0
Total 169

Steps errors 1

Expand to view the steps failures

Installing golang.org/x/tools/cmd/goimports
  • Took 0 min 1 sec . View more details on here
  • Description: go get -u golang.org/x/tools/cmd/goimports

@ycombinator
Copy link
Contributor

Hi @skh, could you try running mage format in the root folder?

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a CHANGELOG entry for this change, please? Thanks!

https://github.com/elastic/package-registry/blob/master/CHANGELOG.md

Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skh skh merged commit 881f3e3 into elastic:master Jan 26, 2021
@skh skh deleted the add-dataset-is-prefix branch January 26, 2021 15:06
@ruflin
Copy link
Member

ruflin commented Jan 26, 2021

Would be nice to have a follow up adding this to one of the test packages: https://github.com/elastic/package-registry/tree/master/testdata/package Then we can see how the actual output looks.

@skh
Copy link
Contributor Author

skh commented Jan 26, 2021

Would be nice to have a follow up adding this to one of the test packages

#676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants