-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
De-dot 'kibana.version' in /package JSON responses #733
De-dot 'kibana.version' in /package JSON responses #733
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
3bf1570
to
ed09685
Compare
This changes the response JSON from ``` "conditions": { "kibana.version": "^7.15.0" }, ``` to ``` "conditions": { "kibana": { "version": "^7.15.0" } }, ``` Closes elastic#730
ed09685
to
a879121
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it doesn't mean that we break the API or just ... unwrap keys :) @ruflin WDYT ?
This might break Fleet. @joshdover @jen-huang Lets make sure the team reviews / tests this before it gets in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and did not see any breaking changes in Fleet, in fact we already had the de-dotted version typed:
https://github.com/elastic/kibana/blob/3eb93a84f52e1c884de06ce089fcd6f1dbbf23fa/x-pack/plugins/fleet/common/types/models/package_spec.ts#L54
I also tested the search endpoint that Fleet uses to query for packages which are compatible, i.e. /search?experimental=true&kibana.version=7.14.1
and that worked as expected too.
This changes the response JSON from
to
Closes #730