Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal parameter from packages and search queries #765

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Nov 8, 2021

The internal flag is not used in any package currently served by the production registry, and it is not part of the spec.

It was used for the base package during development phases, but this package is not needed in final versions, and is not served by the registry since some months ago.

Removing support for this flag in the registry.

@jsoriano jsoriano added the Team:Ecosystem Label for the Packages Ecosystem team label Nov 8, 2021
@jsoriano jsoriano requested a review from a team November 8, 2021 13:19
@jsoriano jsoriano self-assigned this Nov 8, 2021
@elasticmachine
Copy link

elasticmachine commented Nov 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 5 min 15 sec

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Maybe consider also sending an email to the developers' group. I know that this property isn't used, but it's more about dropping the idea of internal packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants