Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return just latest versions in proxy mode /search #873

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Sep 9, 2022

This PR adds the needed changes to return just the latest versions of each package in queries against /search. Related to #849

Scenario:

  • In development:
    • elastic_package_registry version 0.0.4
    • elastic_package_registry version 0.0.5
    • elastic_package_registry version 0.0.6
  • In EPR proxy:
    • Up to 0.0.5 version published of elastic_package_registry

Tested using elastic-package stack up

  • Before:
 $ curl -k -s "https://localhost:8080/search?experimental=true&package=elastic_package_registry" | jq -r .[].version
0.0.5
0.0.6
  • After:
 $ curl -k -s "https://localhost:8080/search?experimental=true&package=elastic_package_registry" | jq -r .[].version
0.0.6

@mrodm mrodm marked this pull request as ready for review September 9, 2022 14:01
@mrodm mrodm self-assigned this Sep 9, 2022
@mrodm mrodm requested a review from a team September 9, 2022 14:01
@elasticmachine
Copy link

elasticmachine commented Sep 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-09T13:59:32.823+0000

  • Duration: 5 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 213
Skipped 0
Total 213

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@@ -13,7 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added

* Update favicon to be the Elastic Package Registry logo. [#858](https://github.com/elastic/package-registry/pull/858)
* Implement proxy mode. [#860](https://github.com/elastic/package-registry/pull/860) [#871](https://github.com/elastic/package-registry/pull/871)
* Implement proxy mode. [#860](https://github.com/elastic/package-registry/pull/860) [#871](https://github.com/elastic/package-registry/pull/871) [#873](https://github.com/elastic/package-registry/pull/873)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there has not been any release with the proxy mode enabled , I've just added this PR here

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants