Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aggregate_metric_double type #457

Closed
Tracked by #132818
ruflin opened this issue Dec 23, 2022 · 2 comments · Fixed by elastic/kibana#154920
Closed
Tracked by #132818

Add support for aggregate_metric_double type #457

ruflin opened this issue Dec 23, 2022 · 2 comments · Fixed by elastic/kibana#154920
Assignees
@jsoriano
Labels
enhancement New feature or request Team:Ecosystem Label for the Packages Ecosystem team tsdb

Comments

@ruflin
Copy link
Collaborator

ruflin commented Dec 23, 2022

For TSDB data streams, the field type aggregate_metric_double was introduced. It seems the field is currently not supported yet as when I started to use the field I got an error message and I couldn't find it in the spec.

Here is the yaml I tried out:

    - name: agg_metric_field
      type: aggregate_metric_double
      metrics: [ "min", "max", "sum", "value_count" ],
      default_metrics: "max"
@ruflin ruflin added enhancement New feature or request Team:Ecosystem Label for the Packages Ecosystem team tsdb labels Dec 23, 2022
@ruflin
Copy link
Collaborator Author

ruflin commented Dec 23, 2022

Note: I added a label tsdb to group all tsdb related issues together.

@ruflin ruflin mentioned this issue Dec 23, 2022
Closed
@joshdover joshdover mentioned this issue Dec 23, 2022
Closed
14 tasks
@jsoriano jsoriano self-assigned this Apr 12, 2023
This was referenced Apr 12, 2023
Merged
Closed
@jsoriano
Copy link
Member

PR open for the package spec: #500
Issue open for support in Kibana: elastic/kibana#154867

@jsoriano jsoriano mentioned this issue Apr 17, 2023
Merged
1 task
jsoriano added a commit to elastic/kibana that referenced this issue Apr 17, 2023
@jsoriano @kibanamachine
[Fleet] Add support for fields of type aggregate_metric_double (#154920)
65a116f 
## Summary

Add support for fields of type `aggregate_metric_double` in EPM.

Change in package spec introduced in
elastic/package-spec#500.

Fixes #154867
Closes elastic/package-spec#457

### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios.

### How to test

* Modify a package to include a field with type
`aggregate_metric_double`, for example like this:
```
    - name: some_metric
      type: aggregate_metric_double
      metrics: [ "min", "max", "sum", "value_count" ]
      default_metric: "max"
```
* Install elastic package with this branch of the package-spec included:
elastic/package-spec#500, for this, from an
elastic-package working directory:
* `go mod edit -replace
github.com/elastic/package-spec/v2=github.com/elastic/package-spec@main`
  * `go mod tidy`
  * `make install`
* Build the package with `elastic-package build -v`.
* Install the package with `elastic-package install -v`.
* Check that the template contains the expected field.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsoriano jsoriano

Labels
enhancement New feature or request Team:Ecosystem Label for the Packages Ecosystem team tsdb
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Add support for fields of type aggregate_metric_double
2 participants
@jsoriano @ruflin