Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to PHONY #138

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Add test to PHONY #138

merged 1 commit into from
Feb 19, 2021

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Feb 19, 2021

What does this PR do?

This PR adjusts the Makefile to fix the missing PHONY statement.

Why is it important?

Tests on master branch are not executed.

Checklist

- [ ] I have added test packages to test/packages that prove my change is effective.
- [ ] I have added an entry in versions/N/changelog.yml.

Related issues

@mtojek mtojek self-assigned this Feb 19, 2021
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #138 opened

  • Start Time: 2021-02-19T13:38:59.519+0000

  • Duration: 2 min 13 sec

  • Commit: ed5d8df

Trends 🧪

Image of Build Times

@mtojek mtojek marked this pull request as ready for review February 19, 2021 13:42
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek merged commit c20d107 into elastic:master Feb 19, 2021
rw-access pushed a commit to rw-access/package-spec that referenced this pull request Mar 23, 2021
* Check if collected documents contain errors

* Try: set ServerName

* Fix: add license header

* Wrap multiErr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants