Support wait-for-data timeout #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
jsoriano
reviewed
Oct 19, 2021
| @@ -8,3 +8,7 @@ spec: | |||
| properties: | |||
| skip: | |||
| $ref: "./../skip.spec.yml#/definitions/skip" | |||
| wait_for_data_timeout: | |||
| description: Short explanation for why test has been skipped. | |||
There was a problem hiding this comment.
Umm, this description is unrelated? 🤔
There was a problem hiding this comment.
My bad, copied this structure from the "skip" definition.
| @@ -8,3 +8,7 @@ spec: | |||
| properties: | |||
| skip: | |||
| $ref: "./../skip.spec.yml#/definitions/skip" | |||
| wait_for_data_timeout: | |||
| description: Short explanation for why test has been skipped. | |||
| type: string | |||
There was a problem hiding this comment.
Q: Are types defined somewhere? Would it be possible to define a duration type for this strings?
There was a problem hiding this comment.
Unfortunately not, these are parts of the JSON schema, not really a Go type.
I think we could improve it with semantic validation (parse its format).
jsoriano
approved these changes
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
Checklist
test/packagesthat prove my change is effective.versions/N/changelog.yml.Related issues