Remove "array" as field data type #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Array doesn't correspond to any type available in Elasticsearch. Instead, Elasticsearch supports setting single or multiple values in the same fields. All values must be of the same type. Stop allowing to define fields as arrays, as this doesn't produce what the package developer is probably expecting.
|
Troubleshooting for package developers migrating added to v2 in elastic/elastic-package#974. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
mtojek
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arraydoesn't correspond to any type available in Elasticsearch. Instead, Elasticsearch supports setting single or multiple values in the same fields. All values must be of the same type.Current implementations in Beats and Fleet assume that
object_typeis set on these cases, and the type defined there is the one finally used in the index template. But there is nothing actually checking this, so we have packages usingtype: arraywithout anobject_type, what doesn't produce a valid mapping.On the cases where
object_typecould be used,typealone can be used to produce the same result, sotype: arraywith anobject_typeis redundant and leads to confusing results.Stop allowing to define fields as arrays, as this doesn't produce what the package developer is probably expecting.
This change will be applied for packages starting on format version 2.0.0.
Closes #408.