Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to define stack capability requirements #561

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jul 5, 2023

What does this PR do?

Add condition to define stack capability requirements.

Why is it important?

There are some features that may be disabled on some deployments, and there are packages that need these features. We need something to indicate the required features so we can prevent users to try to use these packages on deployments where they are not going to work properly.

Checklist

Related issues

@jsoriano jsoriano self-assigned this Jul 5, 2023
@jsoriano jsoriano requested a review from a team as a code owner July 5, 2023 10:03
@elasticmachine
Copy link

elasticmachine commented Jul 5, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-05T14:11:51.177+0000

  • Duration: 13 min 47 sec

Test stats 🧪

Test Results
Failed 0
Passed 894
Skipped 0
Total 894

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (8/8) 💚
Files 70.968% (22/31) 👍
Classes 74.419% (32/43) 👍
Methods 57.778% (78/135) 👍
Lines 43.72% (731/1672) 👍
Conditionals 100.0% (0/0) 💚

mrodm
mrodm previously approved these changes Jul 5, 2023
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a suggestion to avoid duplicated values when defining this new field in a manifest.

spec/integration/manifest.spec.yml Outdated Show resolved Hide resolved
Co-authored-by: Mario Rodriguez Molins <marrodmo@gmail.com>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @jsoriano

@jsoriano jsoriano merged commit dcc37b6 into elastic:main Jul 5, 2023
@jsoriano jsoriano deleted the capabilities-field branch July 5, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Change Proposal] Add new field for dependency on stack capabilities
4 participants