Require type group or nested for fields with subfields #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test integrations |
Closed
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#8048 |
💚 Build Succeeded
cc @jsoriano |
andrewkroh
approved these changes
Oct 2, 2023
| - name: object_with_subfields | ||
| description: This field should be of type group, because it contains subfields. | ||
| type: object | ||
| object_type: keyword |
There was a problem hiding this comment.
object_type is not necessary here, right?
There was a problem hiding this comment.
Yeah, it wouldn't be neccesary to produce this validation error, but I added it so it doesn't trigger also the error about missing object_type for object.
|
test integrations |
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#8065 |
|
Thanks Mario for fixing the integrations jobg! From the packages failed in elastic/integrations#8065, noone fails by linting, so I will merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Require type group for fields with subfields.
Why is it important?
Fields with subfields should not have a definition on their own. This would lead to ambiguity if for
example an object would generate a dynamic mapping, but also definitions for their subelements.
The only cases where a field can contain subfields is when it is of type
group, ornested.Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues