## What does this PR do? #870
Draft
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `kibana/security_ai_prompt` to support security AI prompt assets. ## Why is it important? In order to have the flexibility to tweak AI prompts outside of our regular ESS release schedule, `kibana/security_ai_prompt` assets introduce the ability to ship prompt updates for the security AI Assistant and Attack Discovery. ## Checklist - [x] I have added test packages to [`test/packages`](https://github.com/elastic/package-spec/tree/main/test/packages) that prove my change is effective. - [x] I have added an entry in [`spec/changelog.yml`](https://github.com/elastic/package-spec/blob/main/spec/changelog.yml). ## Related issues - <elastic/security-team#11196>
|
test integrations |
💔 Build Failed
Failed CI StepsHistory |
jsoriano
reviewed
Feb 11, 2025
| - description: A security AI prompt asset file | ||
| type: file | ||
| contentMediaType: "application/json" | ||
| pattern: '^{PACKAGE_NAME}-.+\.json$' |
There was a problem hiding this comment.
How are these prompts related to the data collected by the integration?
If these prompts are not specially related to any data, maybe they should be supported only in content packages.
There was a problem hiding this comment.
A sample package with a more real world use case could help to illustrate this.
| @@ -135,7 +144,7 @@ spec: | |||
| contentMediaType: "application/json" | |||
| pattern: '^{PACKAGE_NAME}-.+\.json$' | |||
| forbiddenPatterns: | |||
| - '^.+-(ecs|ECS)\.json$' # ECS suffix is forbidden | |||
| - '^.+-(ecs|ECS)\.json$' # ECS suffix is forbidden | |||
| versions: | |||
There was a problem hiding this comment.
We should add a version patch so this cannot be used in older versions of the spec.
Suggested change
| versions: | |
| versions: | |
| - before: 3.4.0 | |
| patch: | |
| - op: remove | |
| path: "/contents/6" # remove AI prompt definitions |
Comment on lines
+68
to
+73
| - description: Folder containing security AI prompt assets | ||
| type: folder | ||
| name: security_ai_prompt | ||
| required: false | ||
| contents: | ||
| - description: A security AI prompt asset file |
There was a problem hiding this comment.
Are they specific to security or they could be used in other solutions?
Suggested change
| - description: Folder containing security AI prompt assets | |
| type: folder | |
| name: security_ai_prompt | |
| required: false | |
| contents: | |
| - description: A security AI prompt asset file | |
| - description: Folder containing AI prompt assets | |
| type: folder | |
| name: ai_prompt | |
| required: false | |
| contents: | |
| - description: An AI prompt asset file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
kibana/security_ai_promptto support security AI prompt assets.Why is it important?
In order to have the flexibility to tweak AI prompts outside of our regular ESS release schedule,
kibana/security_ai_promptassets introduce the ability to ship prompt updates for the security AI Assistant and Attack Discovery.Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues
What does this PR do?
Why is it important?
Checklist
test/packagesthat prove my change is effective.spec/changelog.yml.Related issues