Skip to content
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.

Remove logs/metrics categories #97

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jun 30, 2020

The logs and metrics categories do not exist anymore. In elastic/package-registry#534 the supported categories were updated.

The categories are removed for now to allow the registry to remove the legacy support for these categories. The new releases of these packages must contain the new categories.

The logs and metrics categories do not exist anymore. In elastic/package-registry#534 the supported categories were updated.

The categories are removed for now to allow the registry to remove the legacy support for these categories. The new releases of these packages must contain the new categories.
@ruflin ruflin requested a review from mtojek June 30, 2020 09:55
@ruflin ruflin self-assigned this Jun 30, 2020
ruflin added a commit to ruflin/package-registry that referenced this pull request Jun 30, 2020
The metrics and logs categories are not supported anymore. This removes support for it. But it can only be merged after elastic/package-storage#97 landed.
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 30, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-06-30T11:52:35.861+0000

  • Duration: 7 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 12
Skipped 0
Total 12

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more question: does it mean that the import-beats script should be updated to?

EDIT:
Ignore this one, just noticed it's package-storage.

@ruflin ruflin merged commit 4890aaa into elastic:master Jun 30, 2020
@ruflin ruflin deleted the remove-categories branch June 30, 2020 13:59
ruflin added a commit to ruflin/package-registry that referenced this pull request Jun 30, 2020
The metrics and logs categories are not supported anymore. This removes support for it. But it can only be merged after elastic/package-storage#97 landed.
ruflin added a commit to elastic/package-registry that referenced this pull request Jun 30, 2020
The metrics and logs categories are not supported anymore. This removes support for it. But it can only be merged after elastic/package-storage#97 landed.
thomasneirynck pushed a commit to thomasneirynck/package-storage that referenced this pull request Sep 28, 2021
To make sure the registry only serves valid packages, packages should be validated during build time. For this a `Package.Validate() error` method was added. For not it is simple and only checks for title and description but more checks should be added in the future.

The packages which were not valid were updated.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants