Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced Logstash initscript with one tailored for Logstash-forwarder #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

poolski
Copy link

@poolski poolski commented May 5, 2015

This is a self-contained initscript for LSF. It assumes installation in /opt/logstash-forwarder/.

@igalic
Copy link

igalic commented May 6, 2015

shouldn't we just use the one that logstashforwarder creates with pleaserun during its package creation?

@igalic
Copy link

igalic commented May 6, 2015

i just realized that option indirectly exists, and is init_template == undef

@poolski
Copy link
Author

poolski commented May 6, 2015

I do agree that using the initscript generated with pleaserun is more flexible, but this can be a good alternative for when you are just using a binary deployed with Puppet instead of a package.

@electrical
Copy link

Hi,

The init script here is not used by default. we use the packaged init script supplied by LSF it self.
This init script was put in place before LSF had a decent init script in place :-)

@electrical
Copy link

Can one of the admins verify this patch?

@oloc
Copy link

oloc commented Jul 10, 2015

In my opinion the best thing to do is to write a new template of the init script. Why ? Because we need to take care of the definition of some puppet arguments and transfer (sorry for my English) them to the init script.

Something like that :

name=logstash-forwarder
#name=<%= scope.lookupvar('logstashforwarder::lsf_name') %> # need PR #54
program=<%= @installpath %>/bin/$name
args=-config\ <%= @configdir %>/$name.conf

Therefore I pull request #56

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@elasticsearch-release
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants