Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on Elasticsearch's default for source mode in TSDB track #377

Open
pquentin opened this issue Feb 3, 2023 · 0 comments
Open

Rely on Elasticsearch's default for source mode in TSDB track #377

pquentin opened this issue Feb 3, 2023 · 0 comments

Comments

@pquentin
Copy link
Member

pquentin commented Feb 3, 2023

In #375 we changed tsdb's source_mode to synthetic because that was the quickest way to fix CI and nightly tests. However, it would be best to:

  • rely on Elasticsearch defaults, which sets source mode to synthetic for TSDB indices and stored for the rest
  • while still allow setting a specific source mode

I'm not sure how to do that just yet: maybe some advanced Jinja2 is enough, maybe we need a track.py, or maybe it's not possible without a change to Rally itself.

Additionally, it would be nice to not having to copy that logic twice as we had to do in #375.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants