-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ingest pipeline woraround in tsdb track #374
Replace ingest pipeline woraround in tsdb track #374
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you please apply your index-template.json changes to index.json too?
Also, is this possible thanks to improvements in Elasticsearch? What is the latest Elasticsearch branch where this will work?
tsdb/index-template.json
Outdated
"_source": { | ||
"mode": {{ p_source_mode | tojson }} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsdb/operations/default.json
Outdated
{%- if ingest_mode is defined and ingest_mode == "data_stream" %} | ||
"index": "k8s", | ||
{%- else %} | ||
"index": "tsdb", | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the point of this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mistake. I will revert this. This search is ran when running the downsample
challenge and in that case the tsdb-1d
index exists.
@@ -74,7 +78,11 @@ | |||
{ | |||
"name": "date-histo-entire-range", | |||
"operation-type": "search", | |||
{%- if ingest_mode is defined and ingest_mode == "data_stream" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is required otherwise when running with ingest_mode data_stream this search returns no results.
Done.
Yes, tsdb indices use synthetic source by default. Starting from 8.7.0. |
To be clear, "this" was referring to the fact that we can now remove the ingest pipeline. time_series start_time/end_time were introduced in 8.4 I think? I was wondering if something more recent allowed removing that pipeline. I'm assuming it's not thanks to the synthetic source default since it was possible to configure synthetic source with TSDB before 8.7. Anyway, that's only my curiosity. The changes look great now, thank you! |
Yes, this is why it can't be back ported beyond 8.7 |
The workaround is replaced by a workaround that uses fixed start / end time range in the template.
This way there is no need to update document's
@timestamp
value before indexing with an ingest pipeline.The
@timestamp
field values as they are can directly be used. This is beneficial because this doesn'tadd noice of an ingest pipeline to the challenge. Other tsdb challenges don't use a pipeline.
This should allow for running with
ingest_mode
of valuedata_stream
by default. Also in rally nightlies.