Add fetch operations for synthetic source #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `default_1k` operation to nyc_taxis to fetch 1,000 documents. It adds that same operation to tsdb, and another one to fetch 10 documents, similar to nyc_taxis `default` operation. These are all useful to test the fetch speed of synthetic source. Specifically it tests fetching the same documents over and over again. That's useful! It shows that, at least in this case, synthetic source is fast for nyc_taxis: ``` | | | normal | synthetic | | | | 50th percentile service time | default_1k | 10.9269 | 10.5904 | ms | -3.08% | | 90th percentile service time | default_1k | 22.4911 | 15.4604 | ms | -31.26% | | 99th percentile service time | default_1k | 24.4341 | 20.982 | ms | -14.13% | |100th percentile service time | default_1k | 24.9321 | 20.9966 | ms | -15.79% | ``` That's lovely and surprising. It also shows that synthetic source is slow for tsdb, which has many many many fields: ``` | | | normal | synthetic | | | | 50th percentile service time | default_1k | 4.4208 | 163.061 | ms | +3588.48% | | 90th percentile service time | default_1k | 4.6127 | 166.374 | ms | +3506.88% | | 99th percentile service time | default_1k | 5.0065 | 168.403 | ms | +3263.67% | | 100th percentile service time | default_1k | 5.1351 | 173.503 | ms | +3278.76% | ``` It'd be useful to also test fetching *random* docs too - probably more useful and realistic. But this is also useful!
|
Note - this'll add another item to the nightlies for nyc_taxis. |
50 tasks
nik9000
changed the title
pquentin
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
default_1koperation to nyc_taxis to fetch 1,000documents. It adds that same operation to tsdb, and another one to fetch
10 documents, similar to nyc_taxis
defaultoperation. These are alluseful to test the fetch speed of synthetic source. Specifically it
tests fetching the same documents over and over again. That's useful!
It shows that, at least in this case, synthetic source is fast for
nyc_taxis:
That's lovely and surprising. It also shows that synthetic source is
slow for tsdb, which has many many many fields:
It'd be useful to also test fetching random docs too - probably more
useful and realistic. But this is also useful!