Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detection-rules] Add updates for 0.14.1 package #1016

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

brokensound77
Copy link
Contributor

@brokensound77 brokensound77 commented Sep 8, 2021

@brokensound77 brokensound77 merged commit 658a4e4 into elastic:main Sep 8, 2021
@brokensound77 brokensound77 deleted the add-0.14.1-rules branch September 8, 2021 19:26
jmikell821 pushed a commit to jmikell821/security-docs that referenced this pull request Sep 8, 2021
* [Detection-rules] Add updates for 0.14.1 package
jmikell821 pushed a commit to jmikell821/security-docs that referenced this pull request Sep 8, 2021
* [Detection-rules] Add updates for 0.14.1 package
jmikell821 pushed a commit to jmikell821/security-docs that referenced this pull request Sep 8, 2021
* [Detection-rules] Add updates for 0.14.1 package
jmikell821 added a commit that referenced this pull request Sep 8, 2021
* [Detection-rules] Add updates for 0.14.1 package

Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
jmikell821 added a commit that referenced this pull request Sep 8, 2021
* [Detection-rules] Add updates for 0.14.1 package

Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
jmikell821 added a commit that referenced this pull request Sep 9, 2021
* [Detection-rules] Add updates for 0.14.1 package

Co-authored-by: Justin Ibarra <brokensound77@users.noreply.github.com>
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple of typos to fix.

[[prebuilt-rule-0-14-1-aws-security-group-configuration-change-detection]]
=== AWS Security Group Configuration Change Detection

Identifies a change to an AWS Security Group Configuration. A security group is like a virtul firewall and modifying configurations may allow unauthorized access. Threat actors may abuse this to establish persistence, exfiltrate data, or pivot in a AWS environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Identifies a change to an AWS Security Group Configuration. A security group is like a virtul firewall and modifying configurations may allow unauthorized access. Threat actors may abuse this to establish persistence, exfiltrate data, or pivot in a AWS environment.
Identifies a change to an AWS Security Group Configuration. A security group is like a virtual firewall, and modifying configurations may allow unauthorized access. Threat actors may abuse this to establish persistence, exfiltrate data, or pivot in a AWS environment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also recommend changing "a AWS environment" to "an AWS environment" in the last sentence.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about updating "a AWS environment" to "an AWS environment" in the last sentence

|==============================================
|Rule |Description |Status |Version

|<<prebuilt-rule-0-14-1-aws-security-group-configuration-change-detection, AWS Security Group Configuration Change Detection>> | Identifies a change to an AWS Security Group Configuration. A security group is like a virtul firewall and modifying configurations may allow unauthorized access. Threat actors may abuse this to establish persistence, exfiltrate data, or pivot in a AWS environment. | new | 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
|<<prebuilt-rule-0-14-1-aws-security-group-configuration-change-detection, AWS Security Group Configuration Change Detection>> | Identifies a change to an AWS Security Group Configuration. A security group is like a virtul firewall and modifying configurations may allow unauthorized access. Threat actors may abuse this to establish persistence, exfiltrate data, or pivot in a AWS environment. | new | 1
|<<prebuilt-rule-0-14-1-aws-security-group-configuration-change-detection, AWS Security Group Configuration Change Detection>> | Identifies a change to an AWS Security Group Configuration. A security group is like a virtual firewall, and modifying configurations may allow unauthorized access. Threat actors may abuse this to establish persistence, exfiltrate data, or pivot in a AWS environment. | new | 1

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't find any major errors, so LGTM!

[[prebuilt-rule-0-14-1-aws-security-group-configuration-change-detection]]
=== AWS Security Group Configuration Change Detection

Identifies a change to an AWS Security Group Configuration. A security group is like a virtul firewall and modifying configurations may allow unauthorized access. Threat actors may abuse this to establish persistence, exfiltrate data, or pivot in a AWS environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also recommend changing "a AWS environment" to "an AWS environment" in the last sentence.

[[prebuilt-rule-0-14-1-aws-security-group-configuration-change-detection]]
=== AWS Security Group Configuration Change Detection

Identifies a change to an AWS Security Group Configuration. A security group is like a virtul firewall and modifying configurations may allow unauthorized access. Threat actors may abuse this to establish persistence, exfiltrate data, or pivot in a AWS environment.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about updating "a AWS environment" to "an AWS environment" in the last sentence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants