Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #63: Add Endpoint installation instructions #129

Merged
merged 31 commits into from
Aug 18, 2020
Merged

Issue #63: Add Endpoint installation instructions #129

merged 31 commits into from
Aug 18, 2020

Conversation

narcher7
Copy link
Contributor

@narcher7 narcher7 commented Aug 17, 2020 •
edited
Loading

Fixes issue #63

@narcher7 narcher7 self-assigned this Aug 17, 2020
EricDavisX
EricDavisX reviewed Aug 17, 2020
View reviewed changes
docs/getting-started/install-endpoint.asciidoc
[role="screenshot"]
image::images/install-endpoint/endpoint-configuration.png[]
+
4. After the Elastic Agent is installed on your host machine, open a command-line interface, and navigate to your Agent's directory. Copy the commands from Ingest Manager for your OS to enroll and run the Agent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks nice to me, glad we aren't trying to repeat steps (see note below for Stand-alone mode, maybe we shouldn't cite any specific 'command' steps there either... and instead here, and there, we can link to the Ingest Manager docs page for installing Agent. Thoughts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having said that I see nothing bad about the above text, its great - I just think a link would be great too. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EricDavisX: Decided to add the OS commands underneath the image, like they appear in the the Ingest Manager docs. Let me know if that works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what ever you think is best - sounds good to me.

charlie-pichette
charlie-pichette reviewed Aug 17, 2020
View reviewed changes
Copy link

@charlie-pichette charlie-pichette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions.

docs/getting-started/install-endpoint.asciidoc Show resolved Hide resolved
docs/getting-started/install-endpoint.asciidoc Show resolved Hide resolved
docs/getting-started/install-endpoint.asciidoc Outdated Show resolved Hide resolved
@dedemorton
Copy link
Contributor

I don't have time to review this today because I have a bunch of release-related tasks to wrap up. But when the dust settles, let's talk about how we can provide a consistent set of instructions to users. I don't want to send users on an easter egg hunt, but I do think we should be using the same steps to describe the same procedure and that duplicating effort is not a good idea. Even if we decide to make the content available in multiple places, we should make sure we leverage each other's skills to make all the docs better. I think this will be easier when we put the ingest content into the new format where it's not buried in our big, text-only landing page.

@lcawl lcawl mentioned this pull request Aug 18, 2020
Closed
@lcawl lcawl mentioned this pull request Aug 18, 2020
Closed
@narcher7 narcher7 merged commit f2a8ca4 into master Aug 18, 2020
@narcher7 narcher7 deleted the issue-63-endpoint-integration branch August 18, 2020 03:06
benskelker pushed a commit to benskelker/security-docs that referenced this pull request Aug 18, 2020
@narcher7 @lcawl
Issue elastic#63: Add Endpoint installation instructions (elastic#129)
824723c 
* Issue elastic#63: Add Endpoint installation instructions

* Add installation instructions to index

* Small tweak to intro

* add image for verifying datasets. Fix ordered lists

* Remove hosts-overview reference

* Fix ordered list

* Fix level 2 header in preview. Add link to full disk access

* Switch images to new directory

* Fix TOC

* Fix headers

* Fix headers by adding float tags

* Make top Ingest manager a warning

* Address Eriks feedback. Add identifiers to each heder

* Try removing xpack. Incorporate feedback

* Fix code block for beats

* Remove Ingest manager file.

* Remove Ingest Manager warning

* Experiment with header structure

* Rearrange TOC

* Fix toc

* Final TOC fix

* Fix title header on main page

* Another TOC fix

* TOC fixes

* Fix full disk access include

* [DOCS] Updates nesting in Getting Started

* Fix broken link

* Add part intro to Investigate Events section

* Fix Investigate Event build errors

Co-authored-by: lcawl <lcawley@elastic.co>
@benskelker benskelker mentioned this pull request Aug 18, 2020
Merged
benskelker pushed a commit to benskelker/security-docs that referenced this pull request Aug 18, 2020
@narcher7 @lcawl
Issue elastic#63: Add Endpoint installation instructions (elastic#129)
7ebcff5 
* Issue elastic#63: Add Endpoint installation instructions

* Add installation instructions to index

* Small tweak to intro

* add image for verifying datasets. Fix ordered lists

* Remove hosts-overview reference

* Fix ordered list

* Fix level 2 header in preview. Add link to full disk access

* Switch images to new directory

* Fix TOC

* Fix headers

* Fix headers by adding float tags

* Make top Ingest manager a warning

* Address Eriks feedback. Add identifiers to each heder

* Try removing xpack. Incorporate feedback

* Fix code block for beats

* Remove Ingest manager file.

* Remove Ingest Manager warning

* Experiment with header structure

* Rearrange TOC

* Fix toc

* Final TOC fix

* Fix title header on main page

* Another TOC fix

* TOC fixes

* Fix full disk access include

* [DOCS] Updates nesting in Getting Started

* Fix broken link

* Add part intro to Investigate Events section

* Fix Investigate Event build errors

Co-authored-by: lcawl <lcawley@elastic.co>
@benskelker benskelker mentioned this pull request Aug 18, 2020
Merged
benskelker added a commit that referenced this pull request Aug 18, 2020
@benskelker @narcher7 @lcawl
Issue #63: Add Endpoint installation instructions (#129) (#145)
b7b1b8a 
* Issue #63: Add Endpoint installation instructions

* Add installation instructions to index

* Small tweak to intro

* add image for verifying datasets. Fix ordered lists

* Remove hosts-overview reference

* Fix ordered list

* Fix level 2 header in preview. Add link to full disk access

* Switch images to new directory

* Fix TOC

* Fix headers

* Fix headers by adding float tags

* Make top Ingest manager a warning

* Address Eriks feedback. Add identifiers to each heder

* Try removing xpack. Incorporate feedback

* Fix code block for beats

* Remove Ingest manager file.

* Remove Ingest Manager warning

* Experiment with header structure

* Rearrange TOC

* Fix toc

* Final TOC fix

* Fix title header on main page

* Another TOC fix

* TOC fixes

* Fix full disk access include

* [DOCS] Updates nesting in Getting Started

* Fix broken link

* Add part intro to Investigate Events section

* Fix Investigate Event build errors

Co-authored-by: lcawl <lcawley@elastic.co>

Co-authored-by: Nate Archer <12628964+DonNateR@users.noreply.github.com>
Co-authored-by: lcawl <lcawley@elastic.co>
benskelker added a commit that referenced this pull request Aug 18, 2020
@benskelker @narcher7 @lcawl
Issue #63: Add Endpoint installation instructions (#129) (#146)
ccfa515 
* Issue #63: Add Endpoint installation instructions

* Add installation instructions to index

* Small tweak to intro

* add image for verifying datasets. Fix ordered lists

* Remove hosts-overview reference

* Fix ordered list

* Fix level 2 header in preview. Add link to full disk access

* Switch images to new directory

* Fix TOC

* Fix headers

* Fix headers by adding float tags

* Make top Ingest manager a warning

* Address Eriks feedback. Add identifiers to each heder

* Try removing xpack. Incorporate feedback

* Fix code block for beats

* Remove Ingest manager file.

* Remove Ingest Manager warning

* Experiment with header structure

* Rearrange TOC

* Fix toc

* Final TOC fix

* Fix title header on main page

* Another TOC fix

* TOC fixes

* Fix full disk access include

* [DOCS] Updates nesting in Getting Started

* Fix broken link

* Add part intro to Investigate Events section

* Fix Investigate Event build errors

Co-authored-by: lcawl <lcawley@elastic.co>

Co-authored-by: Nate Archer <12628964+DonNateR@users.noreply.github.com>
Co-authored-by: lcawl <lcawley@elastic.co>
@jmikell821 jmikell821 mentioned this pull request Sep 23, 2020
Closed
6 tasks
joepeeples pushed a commit that referenced this pull request Mar 13, 2024
@natasha-moore-elastic
Merge pull request #129 from elastic/issue-42-run-osq-from-alerts
52f3f68 
Osquery section - cleanup: Run Osquery from alerts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlie-pichette charlie-pichette charlie-pichette left review comments

@EricDavisX EricDavisX EricDavisX left review comments

@benskelker benskelker Awaiting requested review from benskelker

@jmikell821 jmikell821 Awaiting requested review from jmikell821

@kevinlog kevinlog Awaiting requested review from kevinlog

@caitlinbetz caitlinbetz Awaiting requested review from caitlinbetz

Assignees

@narcher7 narcher7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@narcher7 @dedemorton @EricDavisX @charlie-pichette @lcawl