Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Example response in "Find Cases by Alert" topic is outdated #1695

Merged
merged 11 commits into from
Mar 10, 2022

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Mar 9, 2022

Fixes #1694.

Preview here. (Fixed outdated example and made some minor edits throughout the topic.)

@nastasha-solomon nastasha-solomon marked this pull request as ready for review March 9, 2022 19:00
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a few suggestions for your consideration

Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but LGTM!

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nastasha-solomon can we get a member of the threat hunting team to review this too? (Never mind, I see you have Christos tagged).

@jmikell821 jmikell821 added the API label Mar 9, 2022
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nastasha-solomon nastasha-solomon merged commit 87ebdaa into main Mar 10, 2022
@nastasha-solomon nastasha-solomon deleted the issue-1694-case-alert-api branch March 10, 2022 16:42
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
mergify bot pushed a commit that referenced this pull request Mar 10, 2022
nastasha-solomon added a commit that referenced this pull request Mar 10, 2022
…ed (backport #1695) (#1711)

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Mar 10, 2022
…ted (backport #1695) (#1712)

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Mar 10, 2022
…ed (backport #1695) (#1713)

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Mar 10, 2022
…ted (backport #1695) (#1714)

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Mar 10, 2022
…ted (backport #1695) (#1715)

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Mar 10, 2022
…ted (backport #1695) (#1716)

Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Example response in "Find Cases by Alert" topic is outdated
5 participants