-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Example response in "Find Cases by Alert" topic is outdated #1695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a few suggestions for your consideration
docs/cases/api/cases-api/cases-api-find-cases-by-alert.asciidoc
Outdated
Show resolved
Hide resolved
docs/cases/api/cases-api/cases-api-find-cases-by-alert.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments but LGTM!
docs/cases/api/cases-api/cases-api-find-cases-by-alert.asciidoc
Outdated
Show resolved
Hide resolved
docs/cases/api/cases-api/cases-api-find-cases-by-alert.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nastasha-solomon can we get a member of the threat hunting team to review this too? (Never mind, I see you have Christos tagged).
docs/cases/api/cases-api/cases-api-find-cases-by-alert.asciidoc
Outdated
Show resolved
Hide resolved
docs/cases/api/cases-api/cases-api-find-cases-by-alert.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
) (cherry picked from commit 87ebdaa)
) (cherry picked from commit 87ebdaa)
) (cherry picked from commit 87ebdaa)
) (cherry picked from commit 87ebdaa)
) (cherry picked from commit 87ebdaa)
) (cherry picked from commit 87ebdaa)
Fixes #1694.
Preview here. (Fixed outdated example and made some minor edits throughout the topic.)