Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] New exceptions UI/UX #2546

Merged
merged 13 commits into from
Oct 13, 2022
Merged

[DOCS] New exceptions UI/UX #2546

merged 13 commits into from
Oct 13, 2022

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Oct 5, 2022 •
edited
Loading

Addresses #2304, which includes the following changes:

  • New functionality that shows users how many rules an exception affects. I added a line to the start of the topic indicating that an exception could affect multiple rules. I also created a short sub-section for the feature titled "Find rules using the same exception". Feel free to suggest a different title.
  • The exceptions tab was split into two tabs: the Rule exceptions tab and the Endpoint exceptions tab. A few notes here:
    • The docs that explained how to add an endpoint exception in 8.4 and earlier already explained the pre-reqs/conditions needed to create an endpoint exception so I didn't change any of it.
    • I changed the screenshot that showed the rule exception tab. Previously, it showed the Alerts tab with the trend table and highlighted the exceptions tab. My screenshot update is the more literal representation :))

Previews:

@nastasha-solomon nastasha-solomon self-assigned this Oct 5, 2022
@nastasha-solomon nastasha-solomon linked an issue Oct 5, 2022 that may be closed by this pull request
[DOCS][Security Solution][Exceptions] - New exceptions UI/UX #2304
Closed
@nastasha-solomon nastasha-solomon marked this pull request as ready for review October 5, 2022 21:08
benironside
benironside reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, left a couple minor suggestions.

docs/detections/detections-ui-exceptions.asciidoc Outdated Show resolved Hide resolved
docs/detections/detections-ui-exceptions.asciidoc Outdated Show resolved Hide resolved
yctercero
yctercero approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Thanks for the updates.

nastasha-solomon and others added 3 commits October 6, 2022 14:39
@nastasha-solomon @benironside
Update docs/detections/detections-ui-exceptions.asciidoc
c51f68e 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon @benironside
Update docs/detections/detections-ui-exceptions.asciidoc
abbaf5a 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon
Merge branch 'main' into issue-2304-exceptions-updates
d9d4cbd
joepeeples
joepeeples reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One edit and a suggestion, thanks!

docs/detections/detections-ui-exceptions.asciidoc Outdated Show resolved Hide resolved
docs/detections/detections-ui-exceptions.asciidoc Outdated Show resolved Hide resolved
jmikell821
jmikell821 reviewed Oct 10, 2022
View reviewed changes
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight comment - LGTM otherwise 👍

docs/detections/detections-ui-exceptions.asciidoc Outdated Show resolved Hide resolved
@joepeeples joepeeples mentioned this pull request Oct 11, 2022
Merged
@nastasha-solomon nastasha-solomon merged commit 6ab108a into main Oct 13, 2022
@nastasha-solomon nastasha-solomon deleted the issue-2304-exceptions-updates branch October 13, 2022 13:55
mergify bot pushed a commit that referenced this pull request Oct 13, 2022
@nastasha-solomon @mergify
[DOCS] New exceptions UI/UX (#2546)
baa0983 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit 6ab108a)
@mergify mergify bot mentioned this pull request Oct 13, 2022
Merged
nastasha-solomon added a commit that referenced this pull request Oct 13, 2022
@mergify @benironside
@joepeeples @nastasha-solomon
[8.5] [DOCS] New exceptions UI/UX (backport #2546) (#2574)
aae07a6 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Co-authored-by: nastasha-solomon <79124755+nastasha-solomon@users.noreply.github.com>
@nastasha-solomon nastasha-solomon mentioned this pull request Oct 13, 2022
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmikell821 jmikell821 jmikell821 left review comments

@joepeeples joepeeples joepeeples left review comments

@benironside benironside benironside left review comments

@yctercero yctercero yctercero approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
Feature: Exceptions Team: Docs Team: Security Platform Includes Cyber Threat Intelligence (CTI) team v8.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOCS][Security Solution][Exceptions] - New exceptions UI/UX
5 participants
@nastasha-solomon @yctercero @jmikell821 @joepeeples @benironside