-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs]Adds 7.10 detection rule updates to API docs #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benskelker
requested review from
spong,
marshallmain,
yctercero,
narcher7,
FrankHassanabad and
jmikell821
October 6, 2020 09:14
benskelker
changed the title
[Docs]Adds detection rule updates to API docs
[Docs]Adds 7.10 detection rule updates to API docs
Oct 6, 2020
benskelker
commented
Oct 7, 2020
benskelker
commented
Oct 7, 2020
spong
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Pinging @FrankHassanabad for Threat Matching and @marshallmain @rylnd @yctercero for EQL if they want to give an extra set of 👀's, but went through the changes and looks good! ++ for the added Request Body
ToC reference links too! 🙂
jmikell821
pushed a commit
to jmikell821/security-docs
that referenced
this pull request
Nov 10, 2020
* adds eql rule to api docs * starts adding threat match rule type * threat-match cont * adds threat-match rule response * update rule api chnages * proofing * Update docs/detections/api/rules/rules-api-create.asciidoc missing dot * Update docs/detections/api/rules/rules-api-create.asciidoc missing dot
jmikell821
pushed a commit
to jmikell821/security-docs
that referenced
this pull request
Nov 10, 2020
* adds eql rule to api docs * starts adding threat match rule type * threat-match cont * adds threat-match rule response * update rule api chnages * proofing * Update docs/detections/api/rules/rules-api-create.asciidoc missing dot * Update docs/detections/api/rules/rules-api-create.asciidoc missing dot
jmikell821
added a commit
that referenced
this pull request
Nov 10, 2020
* adds eql rule to api docs * starts adding threat match rule type * threat-match cont * adds threat-match rule response * update rule api chnages * proofing * Update docs/detections/api/rules/rules-api-create.asciidoc missing dot * Update docs/detections/api/rules/rules-api-create.asciidoc missing dot Co-authored-by: Ben Skelker <54019610+benskelker@users.noreply.github.com>
jmikell821
added a commit
that referenced
this pull request
Nov 10, 2020
* adds eql rule to api docs * starts adding threat match rule type * threat-match cont * adds threat-match rule response * update rule api chnages * proofing * Update docs/detections/api/rules/rules-api-create.asciidoc missing dot * Update docs/detections/api/rules/rules-api-create.asciidoc missing dot Co-authored-by: Ben Skelker <54019610+benskelker@users.noreply.github.com>
joepeeples
pushed a commit
that referenced
this pull request
Mar 13, 2024
* First draft * Adding -detections-suppressed-alerts-details * Refreshed image
joepeeples
pushed a commit
that referenced
this pull request
May 22, 2024
* First draft * Adding -detections-suppressed-alerts-details * Refreshed image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the API docs with new rule types for 7.10.0.
Create rule API preview
Update rule API preview