Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]Adds 7.10 detection rule updates to API docs #270

Merged
merged 8 commits into from
Nov 10, 2020

Conversation

benskelker
Copy link
Contributor

@benskelker benskelker commented Oct 5, 2020

Updates the API docs with new rule types for 7.10.0.

Create rule API preview
Update rule API preview

@benskelker benskelker marked this pull request as ready for review October 6, 2020 09:14
@benskelker benskelker changed the title [Docs]Adds detection rule updates to API docs [Docs]Adds 7.10 detection rule updates to API docs Oct 6, 2020
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pinging @FrankHassanabad for Threat Matching and @marshallmain @rylnd @yctercero for EQL if they want to give an extra set of 👀's, but went through the changes and looks good! ++ for the added Request Body ToC reference links too! 🙂

@jmikell821 jmikell821 merged commit 278b13a into elastic:master Nov 10, 2020
jmikell821 pushed a commit to jmikell821/security-docs that referenced this pull request Nov 10, 2020
* adds eql rule to api docs

* starts adding threat match rule type

* threat-match cont

* adds threat-match rule response

* update rule api chnages

* proofing

* Update docs/detections/api/rules/rules-api-create.asciidoc

missing dot

* Update docs/detections/api/rules/rules-api-create.asciidoc

missing dot
jmikell821 pushed a commit to jmikell821/security-docs that referenced this pull request Nov 10, 2020
* adds eql rule to api docs

* starts adding threat match rule type

* threat-match cont

* adds threat-match rule response

* update rule api chnages

* proofing

* Update docs/detections/api/rules/rules-api-create.asciidoc

missing dot

* Update docs/detections/api/rules/rules-api-create.asciidoc

missing dot
jmikell821 added a commit that referenced this pull request Nov 10, 2020
* adds eql rule to api docs

* starts adding threat match rule type

* threat-match cont

* adds threat-match rule response

* update rule api chnages

* proofing

* Update docs/detections/api/rules/rules-api-create.asciidoc

missing dot

* Update docs/detections/api/rules/rules-api-create.asciidoc

missing dot

Co-authored-by: Ben Skelker <54019610+benskelker@users.noreply.github.com>
jmikell821 added a commit that referenced this pull request Nov 10, 2020
* adds eql rule to api docs

* starts adding threat match rule type

* threat-match cont

* adds threat-match rule response

* update rule api chnages

* proofing

* Update docs/detections/api/rules/rules-api-create.asciidoc

missing dot

* Update docs/detections/api/rules/rules-api-create.asciidoc

missing dot

Co-authored-by: Ben Skelker <54019610+benskelker@users.noreply.github.com>
joepeeples pushed a commit that referenced this pull request Mar 13, 2024
* First draft

* Adding -detections-suppressed-alerts-details

* Refreshed image
joepeeples pushed a commit that referenced this pull request May 22, 2024
* First draft

* Adding -detections-suppressed-alerts-details

* Refreshed image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants