Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarifies note in new terms rule #3943

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Sep 13, 2023

@natasha-moore-elastic natasha-moore-elastic added Team: Detections/Response Detections and Response Feature: Rules v8.6.0 v8.7.0 v8.8.0 v8.9.0 v8.10.0 Effort: Small Issues that can be resolved quickly Effort: Medium Issues that take moderate but not substantial time to complete labels Sep 13, 2023
@natasha-moore-elastic natasha-moore-elastic self-assigned this Sep 13, 2023
@github-actions
Copy link

Documentation previews:

@natasha-moore-elastic natasha-moore-elastic added Priority: Medium Issues that have relevance, but aren't urgent and removed Effort: Medium Issues that take moderate but not substantial time to complete labels Sep 13, 2023
@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review September 13, 2023 13:08
@natasha-moore-elastic natasha-moore-elastic requested a review from a team September 13, 2023 13:09
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you merge this one suggestion, this will be good to go, thanks!

@natasha-moore-elastic natasha-moore-elastic merged commit d31c606 into main Sep 14, 2023
@natasha-moore-elastic natasha-moore-elastic deleted the issue-3898-clarify-new-terms-rule-note branch September 14, 2023 10:08
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)
mergify bot pushed a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
natasha-moore-elastic added a commit that referenced this pull request Sep 14, 2023
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit d31c606)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
joepeeples added a commit that referenced this pull request May 22, 2024
* Add alert suppression clarification note

Per /pull/3879

* Clarify note in new terms rule create

Per /pull/3943

* Update images for QA bugs

Per /pull/3946

* Add new terms rule type to create rule API docs

Per /pull/3914

* Add new terms rule type to *update* rule API docs

Per /pull/3914
acorretti pushed a commit that referenced this pull request Nov 19, 2024
* Clarifies note in new terms rule

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
(cherry picked from commit e4fcb5a)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Feature: Rules Priority: Medium Issues that have relevance, but aren't urgent Team: Detections/Response Detections and Response v8.6.0 v8.7.0 v8.8.0 v8.9.0 v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify "warning" note in New terms rule
3 participants