Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .vscode to .gitignore file #4142

Merged
merged 4 commits into from
Nov 13, 2023
Merged

Add .vscode to .gitignore file #4142

merged 4 commits into from
Nov 13, 2023

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Oct 31, 2023

Add .vscode/ to the .gitignore file for the security-docs repo. This allows contributors to customize their local VS Code app's workspaces without Git trying to track those customizations (which are stored within each repo's .vscode subdirectory).

This is consistent with how many other repos manage their .gitignore files, including Security's own Serverless docs repo.

We're backporting to current live branches (main, 8.11, and 7.17). Those are the branches we're most likely to be updating in the future. If we need to update other branches, we can handle case-by-case.

@joepeeples joepeeples self-assigned this Oct 31, 2023
Copy link

Documentation previews:

@joepeeples joepeeples requested review from jmikell821 and a team October 31, 2023 15:12

This comment was marked as resolved.

Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be out of draft stage yet -- appears so? But LGTM!

@joepeeples
Copy link
Contributor Author

@jmikell821 It's still in draft — I need to check with some of the other teams to see if there's anything else we need to do for this, and how to handle backports. I was planning to get back to this after the 8.11 release crunch.

@joepeeples joepeeples marked this pull request as ready for review November 13, 2023 18:46
@joepeeples joepeeples merged commit 7582837 into main Nov 13, 2023
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 13, 2023
mergify bot pushed a commit that referenced this pull request Nov 13, 2023
@joepeeples joepeeples deleted the update-gitignore-vscode branch November 13, 2023 21:05
joepeeples added a commit that referenced this pull request Nov 13, 2023
(cherry picked from commit 7582837)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
joepeeples added a commit that referenced this pull request Nov 13, 2023
(cherry picked from commit 7582837)

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants