Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new github issue template #4262

Merged
merged 18 commits into from
Nov 30, 2023
Merged

Adds new github issue template #4262

merged 18 commits into from
Nov 30, 2023

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Nov 14, 2023

Fixes #4233 by adding an issue template to elastic/security-docs. This template is intended to support UI text-related requests.

Preview

@benironside benironside self-assigned this Nov 14, 2023
@benironside benironside requested a review from a team as a code owner November 14, 2023 23:13
Copy link

Documentation previews:

Copy link
Contributor

mergify bot commented Nov 14, 2023

This pull request does not have a backport label. Could you fix it @benironside? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together, @benironside! This is all great stuff and should hopefully help ease the effort of filing copy review/assistance requests.

.github/ISSUE_TEMPLATE/ui-copy-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.md Outdated Show resolved Hide resolved
@nastasha-solomon nastasha-solomon requested a review from a team November 16, 2023 21:51
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments. This will be a very useful tool for getting info and tracking UI copy requests, thanks!

.github/ISSUE_TEMPLATE/ui-copy-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.md Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.md Outdated Show resolved Hide resolved
Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
joepeeples
joepeeples previously approved these changes Nov 29, 2023
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very small nits. Thanks!

.github/ISSUE_TEMPLATE/ui-copy-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/ui-copy-request.yaml Outdated Show resolved Hide resolved
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
benironside and others added 7 commits November 29, 2023 16:05
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thank you!

@benironside benironside merged commit f14246c into main Nov 30, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Create new UI copy template
4 participants