Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new Advanced Behavioral Detections section #4296

Merged
merged 18 commits into from
Dec 5, 2023

Conversation

natasha-moore-elastic
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic commented Nov 16, 2023

Contributes to #4227.

Summary of changes:

Previews:

Copy link

Documentation previews:

Copy link
Contributor

mergify bot commented Nov 21, 2023

This pull request is now in conflicts. Could you fix it @natasha-moore-elastic? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-4227-adv-beh-det upstream/issue-4227-adv-beh-det
git merge upstream/main
git push upstream issue-4227-adv-beh-det

@natasha-moore-elastic natasha-moore-elastic marked this pull request as ready for review November 29, 2023 14:36
@natasha-moore-elastic natasha-moore-elastic requested a review from a team as a code owner November 29, 2023 14:36
@natasha-moore-elastic natasha-moore-elastic added Feature: Entity Analytics Features or enhancements for any of the Entity pages Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Large Issues that require significant planning, research, writing, and testing Docset: ESS Issues that apply to docs in the Stack release Team: Entity Analytics labels Nov 29, 2023
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this PR was mostly focused on reorg, but I ended up editing some of content that got moved. A few things jumped out at me, so I left some suggestions for your consideration. Feel free to take them with a grain of salt, I am certainly not the most informed about this set of features. Hope they're helpful, lmk if anything doesn't make sense.


The next-generation risk scoring engine provides greater scalability and performance. It leverages the Elastic SIEM detection engine to generate host and user risk scores from the last 30 days.

It also generates risk scores on a recurring interval, and allows for easy onboarding and management. The engine is built to factor in risks from all {elastic-sec} use cases, and allows you to customize and control how and when risk is calculated.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It also generates risk scores on a recurring interval, and allows for easy onboarding and management. The engine is built to factor in risks from all {elastic-sec} use cases, and allows you to customize and control how and when risk is calculated.
It also generates risk scores on a recurring interval, and allows for easy onboarding and management. The engine is built to factor in risks from all {elastic-sec} use cases, and allows you to customize and control how and when risk is calculated.

"data from... use-cases" seems off to me. Maybe replace with "Data from various sources" or "Data from across SIEM"?

Copy link
Contributor Author

@natasha-moore-elastic natasha-moore-elastic Nov 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure which sentence this suggestion refers to? There's no mention of 'data' in this paragraph.

@benironside benironside requested a review from a team November 29, 2023 21:52
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @natasha-moore-elastic - lots of good feedback here, but we could definitely use @SourinPaul's help to address some of the questions. Incorporate what you can, and once feedback is completely merged we'll do a final pass-through. Thanks for pulling this together!

SourinPaul
SourinPaul previously approved these changes Dec 2, 2023
Copy link

@SourinPaul SourinPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the comments. Looks great.

@SourinPaul SourinPaul requested a review from ajosh0504 December 2, 2023 01:23
@natasha-moore-elastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@jmikell821
Copy link
Contributor

@elasticmachine run elasticsearch-ci/docs

@natasha-moore-elastic
Copy link
Contributor Author

natasha-moore-elastic commented Dec 5, 2023

It looks like the build is failing due to:

04:05:07 INFO:build_docs:Bad cross-document links:
04:05:07 INFO:build_docs:  Kibana [master]: packages/kbn-doc-links/src/get_doc_links.ts contains broken links to:
04:05:07 INFO:build_docs:   - en/security/master/advanced-entity-analytics-overview.html#entity-risk-scoring

@hop-dev, I see that in this PR we added a link to advanced-entity-analytics-overview.html#entity-risk-scoring. We're restructuring the documentation, and Entity risk scoring will be a separate page (entity-risk-scoring.html) once this PR is merged. Could we update the link in the packages/kbn-doc-links/src/get_doc_links.ts file to point to this new location? Hopefully, that should also unblock this build.

@hop-dev
Copy link
Contributor

hop-dev commented Dec 5, 2023

@natasha-moore-elastic here is the PR elastic/kibana#172560

@natasha-moore-elastic
Copy link
Contributor Author

@natasha-moore-elastic here is the PR elastic/kibana#172560

Thanks for the quick turnaround, @hop-dev, I appreciate it!

hop-dev added a commit to elastic/kibana that referenced this pull request Dec 5, 2023
…w page (#172560)

Update: We are now setting the link to a temporary link to get
elastic/security-docs#4296 merged and will then
update to the new page

As requested by @natasha-moore-elastic
[here](elastic/security-docs#4296 (comment))

The entity risk scorign documentation is moving to a new page and we
need to update this link to fix the build in
elastic/security-docs#4296.
@natasha-moore-elastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@natasha-moore-elastic natasha-moore-elastic merged commit e700a62 into main Dec 5, 2023
3 of 4 checks passed
@natasha-moore-elastic natasha-moore-elastic deleted the issue-4227-adv-beh-det branch December 5, 2023 16:44
mergify bot pushed a commit that referenced this pull request Dec 5, 2023
* Adds new Advanced Behavioral Detections section

* Moves L4 pages to L3

* Moves ml-integrations under Behavioral detection use cases

* Adds Advanced Behavioral Detections intro section

* Adds links to AEA page

* Uncomments reference that previously broke the build for no reason

* Replaces verbal reference to ml-integrations

* Removes frontmatter

* Behavioral detection updates

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Apply suggestion from TW review

* Applies review feedback

* Lowercase advanced behavioral detections

* Lowercase entity risk scoring

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit e700a62)
natasha-moore-elastic added a commit that referenced this pull request Dec 5, 2023
* Adds new Advanced Behavioral Detections section

* Moves L4 pages to L3

* Moves ml-integrations under Behavioral detection use cases

* Adds Advanced Behavioral Detections intro section

* Adds links to AEA page

* Uncomments reference that previously broke the build for no reason

* Replaces verbal reference to ml-integrations

* Removes frontmatter

* Behavioral detection updates

* Apply suggestions from code review

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Apply suggestion from TW review

* Applies review feedback

* Lowercase advanced behavioral detections

* Lowercase entity risk scoring

---------

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit e700a62)

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
hop-dev added a commit to elastic/kibana that referenced this pull request Dec 6, 2023
…e new page (#172592)

Follow on from #172560

As requested by @natasha-moore-elastic
elastic/security-docs#4296 (comment)

The entity risk scoring documentation is moving to a new page and we
need to update this link to fix the build in
elastic/security-docs#4296.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Effort: Large Issues that require significant planning, research, writing, and testing Feature: Entity Analytics Features or enhancements for any of the Entity pages Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Entity Analytics v8.11.0 v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entity Analytics: Create new "Advanced Behavioral Detections" topic
5 participants