Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline opens as a modal #4298

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Timeline opens as a modal #4298

merged 3 commits into from
Dec 7, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Nov 16, 2023

Contributes to #4297.

Preview: Removed text that describes Timeline button behavior. Hopefully this makes the instructions more maintainable moving forward.

@nastasha-solomon nastasha-solomon added Team: Threat Hunting Formerly Data Visibility Feature: Timeline Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly v8.12.0 labels Nov 16, 2023
@nastasha-solomon nastasha-solomon self-assigned this Nov 16, 2023
Copy link

Documentation previews:

@nastasha-solomon nastasha-solomon marked this pull request as ready for review December 3, 2023 01:11
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner December 3, 2023 01:11
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nastasha-solomon nastasha-solomon merged commit ac5c7c6 into main Dec 7, 2023
@nastasha-solomon nastasha-solomon deleted the issue-4297-timeline-modal branch December 7, 2023 20:47
@nastasha-solomon nastasha-solomon restored the issue-4297-timeline-modal branch December 7, 2023 20:48
mergify bot pushed a commit that referenced this pull request Dec 7, 2023
(cherry picked from commit ac5c7c6)
nastasha-solomon added a commit that referenced this pull request Dec 7, 2023
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
@nastasha-solomon nastasha-solomon deleted the issue-4297-timeline-modal branch December 21, 2023 22:57
@nastasha-solomon nastasha-solomon mentioned this pull request Jan 12, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Small Issues that can be resolved quickly Feature: Timeline Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Threat Hunting Formerly Data Visibility v8.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants