Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ESS] Timeline docs should be updated with the new UI #4483

Merged
merged 18 commits into from
Jan 2, 2024
Merged

[ESS] Timeline docs should be updated with the new UI #4483

merged 18 commits into from
Jan 2, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Dec 18, 2023 •
edited
Loading

@nastasha-solomon nastasha-solomon added Team: Threat Hunting Formerly Data Visibility Feature: Timeline Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly Docset: ESS Issues that apply to docs in the Stack release v8.12.0 labels Dec 18, 2023
@nastasha-solomon nastasha-solomon self-assigned this Dec 18, 2023
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon nastasha-solomon linked an issue Dec 18, 2023 that may be closed by this pull request
Timeline docs should be updated with the new UI. #4306
Closed
@nastasha-solomon nastasha-solomon marked this pull request as ready for review December 19, 2023 04:01
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner December 19, 2023 04:01
@nastasha-solomon nastasha-solomon mentioned this pull request Dec 20, 2023
Closed
natasha-moore-elastic
natasha-moore-elastic reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of edits based on what I currently see in BC2 – feel free to ignore them if we're expecting this to change between BC2 and the release.

docs/events/timeline-ui-overview.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-ui-overview.asciidoc Show resolved Hide resolved
docs/events/timeline-ui-overview.asciidoc Show resolved Hide resolved
docs/events/timeline-templates.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-templates.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-templates.asciidoc Show resolved Hide resolved
nastasha-solomon and others added 5 commits December 21, 2023 11:35
@nastasha-solomon
Update docs/events/timeline-ui-overview.asciidoc
0fcba33
@nastasha-solomon @natasha-moore-elastic
Update docs/events/timeline-templates.asciidoc
ca1eec2 
Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
@nastasha-solomon @natasha-moore-elastic
Update docs/events/timeline-templates.asciidoc
a7ebc77 
Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
@nastasha-solomon
Merge branch 'main' into issue-4306-timeline-ui-changes
1b1a3f7
@nastasha-solomon
Removing borders
a2cfaac
benironside
benironside previously approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few trivial suggestions, overall LGTM!

docs/events/timeline-templates.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-ui-overview.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-ui-overview.asciidoc Outdated Show resolved Hide resolved
docs/events/timeline-ui-overview.asciidoc Outdated Show resolved Hide resolved
nastasha-solomon and others added 4 commits December 21, 2023 17:36
@nastasha-solomon @benironside
Update docs/events/timeline-ui-overview.asciidoc
bcd3547 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon @benironside
Update docs/events/timeline-ui-overview.asciidoc
abd142f 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon @benironside
Update docs/events/timeline-ui-overview.asciidoc
7b7ba17 
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@nastasha-solomon
Merge branch 'main' into issue-4306-timeline-ui-changes
3b872a0
@nastasha-solomon
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Jan 2, 2024 •
edited
Loading

@elasticmachine run docs-build

@nastasha-solomon nastasha-solomon merged commit 68daf4d into main Jan 2, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Jan 2, 2024
@nastasha-solomon @mergify
[ESS] Timeline docs should be updated with the new UI (#4483)
43e4c78 
* First draft

* Adding more text changes

* Fixed terminology

* Updating IG page

* Refreshing

* Adding Nat's edits

* Update docs/events/timeline-ui-overview.asciidoc

* Update docs/events/timeline-templates.asciidoc

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Update docs/events/timeline-templates.asciidoc

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Removing borders

* Removed breadcrumb trail

* Update docs/events/timeline-templates.asciidoc

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 68daf4d)
@mergify mergify bot mentioned this pull request Jan 2, 2024
Merged
nastasha-solomon added a commit that referenced this pull request Jan 2, 2024
@mergify @nastasha-solomon
[8.12] [ESS] Timeline docs should be updated with the new UI (backport …
d2367d7 
…#4483) (#4537)

* First draft

* Adding more text changes

* Fixed terminology

* Updating IG page

* Refreshing

* Adding Nat's edits

* Update docs/events/timeline-ui-overview.asciidoc

* Update docs/events/timeline-templates.asciidoc

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Update docs/events/timeline-templates.asciidoc

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Removing borders

* Removed breadcrumb trail

* Update docs/events/timeline-templates.asciidoc

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

* Update docs/events/timeline-ui-overview.asciidoc

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
(cherry picked from commit 68daf4d)

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
@nastasha-solomon nastasha-solomon deleted the issue-4306-timeline-ui-changes branch January 2, 2024 23:01
@nastasha-solomon nastasha-solomon mentioned this pull request Jan 12, 2024
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha-moore-elastic natasha-moore-elastic natasha-moore-elastic approved these changes

@benironside benironside benironside left review comments

Assignees

@nastasha-solomon nastasha-solomon

Labels
Docset: ESS Issues that apply to docs in the Stack release Effort: Small Issues that can be resolved quickly Feature: Timeline Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Threat Hunting Formerly Data Visibility v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeline docs should be updated with the new UI.
3 participants
@nastasha-solomon @benironside @natasha-moore-elastic