Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport query rule alert suppression to API docs #4496

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Dec 20, 2023

Contributes to #4481. We need to backport query rule alert suppression into the API docs back to 8.6.

We'll have to use the backport tool to create the backport PRs, since this PR is targeting the 8.11 branch (and not main which Mergify watches).

#4479 is updating docs for 8.12 and onward.

Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Somehow the previous commit omitted this file
@joepeeples joepeeples marked this pull request as ready for review December 20, 2023 20:18
@joepeeples joepeeples requested a review from a team December 20, 2023 20:18
docs/detections/api/rules/rules-api-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-update.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-update.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-update.asciidoc Outdated Show resolved Hide resolved
joepeeples and others added 2 commits January 3, 2024 16:53
Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
Copy link
Contributor Author

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply duration edits from Natasha's review

docs/detections/api/rules/rules-api-create.asciidoc Outdated Show resolved Hide resolved
docs/detections/api/rules/rules-api-update.asciidoc Outdated Show resolved Hide resolved
@joepeeples joepeeples merged commit 49831d3 into 8.11 Jan 4, 2024
4 checks passed
joepeeples added a commit to joepeeples/security-docs that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit to joepeeples/security-docs that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit to joepeeples/security-docs that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit to joepeeples/security-docs that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit to joepeeples/security-docs that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
joepeeples added a commit that referenced this pull request Jan 4, 2024
* Add query rule alert suppression to API docs

* Update rules-api-create.asciidoc

Somehow the previous commit omitted this file

* Apply suggestions from Natasha's review

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>

* Apply `duration` edits from Natasha's review

---------

Co-authored-by: natasha-moore-elastic <137783811+natasha-moore-elastic@users.noreply.github.com>
# Conflicts:
#	docs/detections/api/rules/rules-api-create.asciidoc
@joepeeples joepeeples deleted the 4481-API-alert-suppression-backports branch January 4, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants