Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][ESS][8.12] Screenshot needs to be updated for the missing ES|QL tab in timeline #4499

Merged
merged 4 commits into from
Dec 21, 2023
Merged

[Bug][ESS][8.12] Screenshot needs to be updated for the missing ES|QL tab in timeline #4499

merged 4 commits into from
Dec 21, 2023

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Dec 20, 2023 •
edited
Loading

Contributes to #4223

Preview - Updates screenshots

@nastasha-solomon nastasha-solomon added Team: Threat Hunting Formerly Data Visibility Feature: Timeline Priority: Low Issues that need attention, but are not urgent Effort: Small Issues that can be resolved quickly v8.12.0 labels Dec 20, 2023
@nastasha-solomon nastasha-solomon self-assigned this Dec 20, 2023
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon nastasha-solomon mentioned this pull request Dec 20, 2023
Closed
@nastasha-solomon nastasha-solomon changed the title [Bug][8.12] Screenshot needs to be updated for the missing ES|QL tab in timeline [Bug][ESS][8.12] Screenshot needs to be updated for the missing ES|QL tab in timeline Dec 20, 2023
@nastasha-solomon nastasha-solomon linked an issue Dec 20, 2023 that may be closed by this pull request
[Bug] Screenshot needs to be updated for the missing ES|QL tab in timeline #4223
Closed
@nastasha-solomon nastasha-solomon marked this pull request as ready for review December 21, 2023 15:41
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner December 21, 2023 15:41
@nastasha-solomon nastasha-solomon requested a review from a user December 21, 2023 15:46
ghost
ghost approved these changes Dec 21, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requested changes are now fixed 👍

benironside
benironside approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nastasha-solomon nastasha-solomon merged commit 560ce5f into main Dec 21, 2023
4 checks passed
mergify bot pushed a commit that referenced this pull request Dec 21, 2023
@nastasha-solomon @mergify
[Bug][ESS][8.12] Screenshot needs to be updated for the missing ES|QL…
1dd5760 
… tab in timeline (#4499)

* Updating one indicator image

* Refreshing last image

* Updated hash value in example

(cherry picked from commit 560ce5f)
@mergify mergify bot mentioned this pull request Dec 21, 2023
Merged
nastasha-solomon added a commit that referenced this pull request Dec 21, 2023
@mergify @nastasha-solomon
[8.12] [Bug][ESS][8.12] Screenshot needs to be updated for the missin…
ce3d919 
…g ES|QL tab in timeline (backport #4499) (#4521)

* Updating one indicator image

* Refreshing last image

* Updated hash value in example

(cherry picked from commit 560ce5f)

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
@nastasha-solomon nastasha-solomon deleted the issue-4223-esql-timeline-8.12 branch December 21, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benironside benironside benironside approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels
Effort: Small Issues that can be resolved quickly Feature: Timeline Priority: Low Issues that need attention, but are not urgent Team: Threat Hunting Formerly Data Visibility v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Screenshot needs to be updated for the missing ES|QL tab in timeline
2 participants
@nastasha-solomon @benironside