Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documents Attack Discovery feature #5100

Merged
merged 13 commits into from
May 13, 2024
Merged

Documents Attack Discovery feature #5100

merged 13 commits into from
May 13, 2024

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Apr 18, 2024 •
edited
Loading

Fixes #5026. Creates a new page about AI Attack Discovery. Twin serverless PR was already reviewed, this is based on the reviewed version.

Preview: Attack Discovery

@benironside benironside added Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Large Issues that require significant planning, research, writing, and testing Feature: Elastic AI Assistant Interface for interacting with generative AIs v8.14.0 labels Apr 18, 2024
@benironside benironside self-assigned this Apr 18, 2024
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@benironside benironside changed the title Documents AI Insights Documents Attack Discovery feature Apr 18, 2024
@benironside benironside marked this pull request as ready for review May 13, 2024 16:10
@benironside benironside requested a review from a team as a code owner May 13, 2024 16:10
joepeeples
joepeeples reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content, exciting feature! I added a few small formatting edits, some of which might also need to be applied to the ESS docs for parity. Ping me again once everything's ready and I can approve.

docs/attack-discovery/attack-discovery.asciidoc Outdated Show resolved Hide resolved
docs/attack-discovery/attack-discovery.asciidoc Outdated Show resolved Hide resolved
docs/attack-discovery/attack-discovery.asciidoc Outdated Show resolved Hide resolved
docs/attack-discovery/attack-discovery.asciidoc Outdated Show resolved Hide resolved
docs/attack-discovery/attack-discovery.asciidoc Show resolved Hide resolved
docs/attack-discovery/attack-discovery.asciidoc Outdated Show resolved Hide resolved
docs/attack-discovery/attack-discovery.asciidoc Outdated Show resolved Hide resolved
docs/attack-discovery/attack-discovery.asciidoc Outdated Show resolved Hide resolved
joepeeples
joepeeples previously approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪨

@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024

This pull request is now in conflicts. Could you fix it @benironside? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 5026-ai-insights-newpg upstream/5026-ai-insights-newpg
git merge upstream/main
git push upstream 5026-ai-insights-newpg

@benironside benironside merged commit e9ec60e into main May 13, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request May 13, 2024
@benironside @mergify
Documents Attack Discovery feature (#5100)
ab74f1b 
* creates stub page

* updates feature name

* update screenshot

* Adds Attack Discovery ESS page

* adds attack discovery to index

* troubleshoots build error

* troubleshoots ToC issue

* troubleshoots build errors

* incorporates Joe's edits

---------

Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit e9ec60e)
@mergify mergify bot mentioned this pull request May 13, 2024
Merged
mergify bot pushed a commit that referenced this pull request May 13, 2024
@benironside @mergify
Documents Attack Discovery feature (#5100)
8bde962 
* creates stub page

* updates feature name

* update screenshot

* Adds Attack Discovery ESS page

* adds attack discovery to index

* troubleshoots build error

* troubleshoots ToC issue

* troubleshoots build errors

* incorporates Joe's edits

---------

Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit e9ec60e)
@mergify mergify bot mentioned this pull request May 13, 2024
Merged
benironside added a commit that referenced this pull request May 13, 2024
@mergify @benironside
Documents Attack Discovery feature (#5100) (#5207)
bc526ca 
* creates stub page

* updates feature name

* update screenshot

* Adds Attack Discovery ESS page

* adds attack discovery to index

* troubleshoots build error

* troubleshoots ToC issue

* troubleshoots build errors

* incorporates Joe's edits

---------

Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit e9ec60e)

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
benironside added a commit that referenced this pull request May 13, 2024
@mergify @benironside
Documents Attack Discovery feature (#5100) (#5208)
101d21d 
* creates stub page

* updates feature name

* update screenshot

* Adds Attack Discovery ESS page

* adds attack discovery to index

* troubleshoots build error

* troubleshoots ToC issue

* troubleshoots build errors

* incorporates Joe's edits

---------

Co-authored-by: Janeen Mikell Roberts <57149392+jmikell821@users.noreply.github.com>
(cherry picked from commit e9ec60e)

Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
@benironside benironside mentioned this pull request May 16, 2024
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples approved these changes

Assignees

@benironside benironside

Labels
Effort: Large Issues that require significant planning, research, writing, and testing Feature: Elastic AI Assistant Interface for interacting with generative AIs Priority: High Issues that are time-sensitive and/or are of high customer importance v8.13.0 v8.14.0
Projects
Elastic Security Docs Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Document Attack Discovery
3 participants
@benironside @joepeeples @jmikell821