-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request][ESS] Document advanced setting that allows users to disable ES|QL in ESS #5181
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text itself LGTM, but I'm not sure why we need to remind users in all these places that they can turn off ES|QL. If a user goes to a section like "Create an ES|QL rule" or "Use ES|QL to investigate events," they're not trying to turn off the entire language — they want to use it. Maybe there's a different context where it'd be more natural to tell users how to disable ES|QL if they don't want to use it?
Looking at this again, I don't think we need to put this notice in the places where users are creating a new ES|QL rule from the UI. I agree that if they've landed on those instructions, they've already decided to create an ES|QL rule. But I do think it's important to keep the note in the places that provide background on the ES|QL features in Security to ensure it's visible in the places where users go to learn about the feature. Here's where I think it'd be appropriate:
I also think we can change the focus of the message to let users know that there's a single advanced setting that controls all ES|QL features in ESS. Here's what I'm thinking: ES|QL features are turned on by default and are controlled by the @joepeeples and @paulewing let me know your thoughts on what I've laid out above. |
Thanks @nastasha-solomon, here are some direct responses:
Definitely agree! Ideally there'd be a single location where we can document this, instead of having the same message repeated across several topics. But repeating might be unavoidable.
This section appears to have two duplicate notes about the same thing — or maybe it's two different things that, at first (and second) glance look like the same thing? Either way it's confusing.
LGTM! |
@joepeeples yeah, within the Security docs, there's no one single place to add the information about the advanced setting. There is this page over on the Elasticsearch side, but it's in the ES docset, so it's a bit out of the way for Security users. Plus, I feel like Using ES|QL page would be the better place to put the advanced setting information. I'll ping Liam about this next week to get his thoughts on adding the advanced setting information to the ES|QL docs. RE the second note that you pointed out under the Timeline docs: |
This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
|
I pinged the ES|QL writer to check whether they're mentioning the advanced setting in the core ES|QL docs. Will report back here once I know more. |
…disable ES|QL in ESS (backport #5181) (#5234) * First draft * Minor edits * Updated note * Removing outdated content * Update docs/assistant/security-assistant.asciidoc * Update docs/detections/about-rules.asciidoc * Update docs/events/timeline-ui-overview.asciidoc * Fixed formatting (cherry picked from commit 84344d6) Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Contributes to #5163 and #5149
Previews: A note about the
enableESQL
advanced setting was added to the following locations:No Serverless PR was created. The advanced setting is only available in ESS right now.