Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request][Serverless & 8.15]: Expandable flyout setting being removed from advanced settings #5292

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented May 31, 2024

Fixes #5291 by removing docs for the securitySolution:enableExpandableFlyout advanced setting.

ESS previews:

Serverless previews:

@nastasha-solomon nastasha-solomon added Team: Threat Hunting Formerly Data Visibility Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Small Issues that can be resolved quickly Docset: Serverless Issues for Serverless Security Docset: ESS Issues that apply to docs in the Stack release v8.15.0 ci:doc-build labels May 31, 2024
@nastasha-solomon nastasha-solomon self-assigned this May 31, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@elasticdocs
Copy link

elasticdocs commented May 31, 2024

🚀 Built co-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nastasha-solomon nastasha-solomon marked this pull request as ready for review May 31, 2024 20:45
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner May 31, 2024 20:45
PhilippeOberti
PhilippeOberti previously approved these changes May 31, 2024
@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Jun 4, 2024

@PhilippeOberti merged elastic/kibana#184169 today, so the change should be included in next week's Serverless release, which is currently scheduled to begin on June 10.

Before I merge this PR, I need to verify that the securitySolution:enableExpandableFlyout advanced setting is no longer visible on the Advanced Settings page in Serverless -- QA and prod envs. It'd also be worth spot-checking areas where the expandable flyout is used, such as Timeline (events and alerts), the Hosts page (host details), and the Users page (user details).

If a backport PR is created (which is very unlikely because the 8.15 docs branch hasn't been cut yet), I'll need to remove Serverless files from the backport PR.

@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Jun 11, 2024

I checked the QA server and confirmed that the securitySolution:enableExpandableFlyout setting isn't available on the Advanced Settings page. Today and tomorrow, I'll watch the Kibana release tracker and periodically check our Canary Prod project to see if this change has been promoted.

Copy link
Contributor

mergify bot commented Jun 12, 2024

This pull request is now in conflicts. Could you fix it @nastasha-solomon? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b issue-5291-expand-flyout-removed upstream/issue-5291-expand-flyout-removed
git merge upstream/main
git push upstream issue-5291-expand-flyout-removed

@nastasha-solomon
Copy link
Contributor Author

Validated that the change is available on the Prod Canary Server. Dashboard shows that the promotion to Prod Noncanary is complete too, so can merge tomorrow.

@nastasha-solomon nastasha-solomon requested a review from a team June 13, 2024 01:41
@elasticdocs
Copy link

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@nastasha-solomon nastasha-solomon merged commit 74ad93d into main Jun 13, 2024
4 checks passed
@nastasha-solomon nastasha-solomon deleted the issue-5291-expand-flyout-removed branch June 13, 2024 14:56
@nastasha-solomon nastasha-solomon mentioned this pull request Aug 6, 2024
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docset: ESS Issues that apply to docs in the Stack release Docset: Serverless Issues for Serverless Security Effort: Small Issues that can be resolved quickly Priority: High Issues that are time-sensitive and/or are of high customer importance Team: Threat Hunting Formerly Data Visibility v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request][Serverless & 8.15]: Expandable flyout setting being removed from advanced settings
4 participants