Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless] Adds auto import page #5560

Merged
merged 16 commits into from
Aug 7, 2024
Merged

Conversation

benironside
Copy link
Contributor

@benironside benironside commented Jul 14, 2024

Addresses #5272 by adding a page for the "auto import" feature to the "ingest" section of serverless docs. ESS version to follow.

Preview: Auto import

@benironside benironside added Feature: Integrations Team: GenAI Generative AI team Docset: Serverless Issues for Serverless Security labels Jul 14, 2024
@benironside benironside self-assigned this Jul 14, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Jul 14, 2024

This pull request does not have a backport label. Could you fix it @benironside? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@elasticdocs
Copy link

elasticdocs commented Jul 14, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@benironside benironside requested a review from jamiehynds July 15, 2024 00:33
@benironside benironside marked this pull request as ready for review July 31, 2024 04:11
@benironside benironside requested a review from a team as a code owner July 31, 2024 04:11
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments for your review. Thanks for pulling it together! Would like to review again after other feedback with fresh eyes, in case I missed a few things.

docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great content! Hopefully these suggestions are helpful and easy to implement.

docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@natasha-moore-elastic natasha-moore-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor suggestions, otherwise looks good!

docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@jmikell821 jmikell821 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments to tidy this up, then it'll be good to go! Feel free to have another team member give it the once-over before merging. Thank you!

docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
docs/serverless/ingest/auto-import.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@benironside benironside merged commit 6d77a03 into main Aug 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants