Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes tech preview banners and technical preview limitations page #6187

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

benironside
Copy link
Contributor

Important

Do not merge until Nov 20.

Resolves https://github.com/elastic/security-docs-internal/issues/41 by removing the "Technical Preview" badges at the top of every serverless docs page. Also removes the Technical preview limitations page entirely.

Previews

There's too many affected pages to check them all, but some spot-checking would be good.

@benironside benironside self-assigned this Nov 19, 2024
@benironside benironside requested a review from a team as a code owner November 19, 2024 23:24
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Nov 19, 2024

This pull request does not have a backport label. Could you fix it @benironside? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@nastasha-solomon nastasha-solomon added Effort: Large Issues that require significant planning, research, writing, and testing Priority: Urgent Issues that need to be resolved as soon as possible Docset: Serverless Issues for Serverless Security labels Nov 20, 2024
Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did the following to review this PR and found no major issues:

  • Spot-checked the output to see if there were any formatting issues that came from removing the tech preview tag. I didn't notice any.

  • Pulled down the branch to check for remaining instances of the preview:[] tag. There are only a handful, and each instance looks to be necessary and correct.

    Screenshot 2024-11-20 at 9 16 58 AM

@nastasha-solomon nastasha-solomon merged commit 9727cd4 into main Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Docset: Serverless Issues for Serverless Security Effort: Large Issues that require significant planning, research, writing, and testing Priority: Urgent Issues that need to be resolved as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants