Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Known issue][Detection Engine][8.16.0 & 8.16.1] Exception item comment validation on newline chars #6280
base: 8.x
Are you sure you want to change the base?
[Known issue][Detection Engine][8.16.0 & 8.16.1] Exception item comment validation on newline chars #6280
Changes from 11 commits
f1381d4
8373c60
de5a222
38581f6
0ca9743
6976042
6defa72
7183210
e3f82b0
9bf6c65
e20aef0
90394fc
2be7285
4d0cfdc
1d01413
1c63272
526e180
3718daa
74deb37
598a11f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how we usually document curl requests, do we need to specify that they need to also include the space? If not, ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, I'm not sure. Do users still need to specify the space if they're using the default one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe so, think just if they need to hit a different space. Might be worth just noting somewhere though to make sure to include space if other than default?