implement module #1
Conversation
| class SetCookie { | ||
| constructor (input, options) { | ||
| if (Array.isArray(input)) { | ||
| return input.map(item => new SetCookie(item, options)) |
There was a problem hiding this comment.
Will this work if people do new SetCookie(array)?
There was a problem hiding this comment.
Yep, it will return an array of SetCookie instances.
There was a problem hiding this comment.
Will return statements not be ignored inside of a constructor?
There was a problem hiding this comment.
Nope, if you return in a constructor, the return value of the new Constructor will be whatever was returned. 😸
There was a problem hiding this comment.
The tests prove this already, by the way. 😸
index.js
Outdated
| maxAge: undefined, | ||
| domain: undefined, | ||
| path: undefined, | ||
| secure: undefined, |
There was a problem hiding this comment.
Consider setting this default value to false
index.js
Outdated
| domain: undefined, | ||
| path: undefined, | ||
| secure: undefined, | ||
| httpOnly: undefined, |
There was a problem hiding this comment.
Consider setting this default value to false
index.js
Outdated
| } | ||
|
|
||
| data = { | ||
| key: this[decode](pair[0]), |
There was a problem hiding this comment.
From https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie:
__Secure-prefix: Cookies with a name starting with__Secure-(dash is part of the prefix) must be set with thesecureflag and must be from a secure page (HTTPS).__Host-prefix: Cookies with a name starting with__Host-must be set with thesecureflag, must be from a secure page (HTTPS), must not have a domain specified (and therefore aren't sent to subdomains) and the path must be "/".
|
@watson Can I get another review of this? |
This is an initial implementation of a set-cookie parser and serializer.