Skip to content

Conversation

@dedemorton
Copy link
Contributor

Closes #180

@tbragin
Copy link

tbragin commented Jan 12, 2019

LGTM!

Copy link

@tbragin tbragin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Jumping around is unfortunate, but I can see why it's necessary within our docs structure today. It would be nice to have ability to duplicate key snippets, such as specifically how to customize Logs UI and Infrastructure UI index configuration right inline.

@dedemorton
Copy link
Contributor Author

It would be nice to have ability to duplicate key snippets, such as specifically how to customize Logs UI and Infrastructure UI index configuration right inline.

@tbragin Agreed. We do have a place in the docs repo where we can store content shared across books, but I've noticed that folks forget to update those files. The files don't show up in a repo search, so maintainers don't think to update them. So I hesitate to use that approach right now. I'd really like us to resolve the larger problem with our information architecture because the fragmentation of content is pervasive and not a great user experience. Having our content in silos organized by product is a legacy problem that's going to take a concentrated effort and investment to resolve. :-/ I'm looking forward to talking more with you about the issue, especially wrt the observability and beats docs.

Copy link
Contributor

@DanRoscigno DanRoscigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dedemorton dedemorton merged commit 9ea4e83 into elastic:master Jan 14, 2019
bmorelli25 pushed a commit that referenced this pull request Feb 15, 2019
bmorelli25 pushed a commit that referenced this pull request Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants