Skip to content

Incorporate review comments in preparation for beta release 7.2 #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karenzone merged 2 commits into from
Jun 17, 2019
Merged

Incorporate review comments in preparation for beta release 7.2 #373

karenzone merged 2 commits into from
Jun 17, 2019

Conversation

@karenzone
Copy link
Contributor

@karenzone karenzone commented Jun 14, 2019

This PR:

  • replaces architecture graphic placeholder (Thanks, Mike!)
  • Incorporates fixes and review comments for beta release of the Siem Guide

@karenzone karenzone added the WIP Work in progress label Jun 14, 2019
@lcawl lcawl mentioned this pull request Jun 14, 2019
Closed
@karenzone
Copy link
Contributor Author

karenzone commented Jun 17, 2019

Still failing on:

20:53:41 INFO:build_docs:Bad cross-document links:
20:53:41 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/kibana/7.2/creating-df-kib.html:
20:53:41 INFO:build_docs:   - en/elastic-stack-overview/7.2/ecommerce-dataframes.html

@karenzone karenzone removed the WIP Work in progress label Jun 17, 2019
@karenzone karenzone changed the title [WIP] Incorporate review comments in preparation for beta release 7.2 Incorporate review comments in preparation for beta release 7.2 Jun 17, 2019
@lcawl
Copy link
Contributor

lcawl commented Jun 17, 2019

The build succeeds if you rebase on 7.2, so I think you're good to go

@karenzone karenzone merged commit 8da8225 into elastic:7.2 Jun 17, 2019
@karenzone karenzone deleted the finalize-siem-beta branch June 17, 2019 16:41
This was referenced Jun 17, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karenzone @lcawl