Skip to content

Conversation

@szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Jan 14, 2020

This PR adds a limitation item about imbalanced class sizes to the limitation section and mentions the issue in the classification conceptual documentation.

Docs preview: http://stack-docs_806.docs-preview.app.elstc.co/guide/en/machine-learning/master/ml-dfa-limitations.html

Copy link
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just a few minor suggestions

Co-Authored-By: Tom Veasey <tveasey@users.noreply.github.com>
@szabosteve
Copy link
Contributor Author

@tveasey Thank you for the review. I addressed your feedback and added a defining clause to the sentence in the classification conceptual documentation to explain what "balanced dataset" means.

Copy link
Contributor

@tveasey tveasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szabosteve szabosteve merged commit 0671cde into elastic:master Jan 17, 2020
@szabosteve szabosteve deleted the imbalanced.classes branch January 17, 2020 08:12
szabosteve added a commit to szabosteve/stack-docs that referenced this pull request Jan 17, 2020
…ation (elastic#806)

Co-Authored-By: Tom Veasey <tveasey@users.noreply.github.com>
szabosteve added a commit to szabosteve/stack-docs that referenced this pull request Jan 17, 2020
…ation (elastic#806)

Co-Authored-By: Tom Veasey <tveasey@users.noreply.github.com>
szabosteve added a commit to szabosteve/stack-docs that referenced this pull request Jan 17, 2020
…ation (elastic#806)

Co-Authored-By: Tom Veasey <tveasey@users.noreply.github.com>
@szabosteve
Copy link
Contributor Author

Backport commits:
7.x: ba64d51
7.6: 0f4dbac
7.5: 92eb563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants