Dont overwrite deployment id with self #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfigured to the current deployment id
dimuon
reviewed
Mar 4, 2024
ec/ecresource/deploymentresource/deployment/v2/deployment_read_test.go
Outdated
Show resolved
Hide resolved
dimuon
reviewed
Mar 4, 2024
dimuon
reviewed
Mar 4, 2024
…ployment-id-with-self * upstream/master: Persist snapshot source in the read response (elastic#788) Stateless resources require kibana (elastic#792) Fixed error when universal profiling is activated (elastic#783) fix(deps): update module github.com/hashicorp/terraform-plugin-framework to v1.6.0 (elastic#790)
dimuon
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the TF config explicitly uses the current deployment id as the observability deployment id we shouldn't rewrite the read value to
self.Related Issues
Fixes #782
How Has This Been Tested?
Unit tests
Types of Changes
Readiness Checklist