Fixed error when universal profiling is activated #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `profiling` and `symbols` endpoints were not being read from the response payload, causing an error.
Firstly, this PR is awesome, and it's great to include these endpoints in the resource. That said, this PR does not fix the linked issue, that issue is not present in 0.6 and higher. |
|
@3kt thanks for adding these in 🎉 |
tobio
added a commit
to tobio/terraform-provider-ec
that referenced
this pull request
Mar 11, 2024
…ployment-id-with-self * upstream/master: Persist snapshot source in the read response (elastic#788) Stateless resources require kibana (elastic#792) Fixed error when universal profiling is activated (elastic#783) fix(deps): update module github.com/hashicorp/terraform-plugin-framework to v1.6.0 (elastic#790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
profilingandsymbolsendpoints were not being read from the response payload,causing an error.Description
When activating universal profiling in Kibana (
/app/profilingin Kibana), several new endpoints are added to the deployment:These were not recognized by the provider,
leading to a deadlock situation where the deployment cannot be administered through terraform anymore. This PR fixes this problem. This PR adds the ability to correctly parse the endpoints in the response.Related Issues
Fixes #781The related issue is fixed in 0.6+.
Motivation and Context
See the above description.
How Has This Been Tested?
Unit tested.
AFAICT there's no acceptance test covering this, it might make sense to write one though?
I've also ran the setup described in the issue linked above, and was able to complete the workflow without error.
Types of Changes
Readiness Checklist
Regarding the acceptance tests, I tried to run them per the contributing guidelines, but faced quite some failures with cryptic error messages. A second pass will be very welcome, as I'm not sure I ran them properly.
edit: modified PR definition to reflect that this is a new feature rather than a bug fix