docs: explain Go symbol hash #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Put an explicit description of the Go symbol hash algorithm in the godoc and in the README.
andrewkroh
approved these changes
Oct 31, 2022
|
|
||
| The `GoSymbolHash` algorithm is analogous to the algorithm described for `ImportHash` with the exception that Go's static symbols are used in place of the dynamic import symbols used by `ImportHash`. | ||
|
|
||
| The list of symbols referenced by the executable is obtained and the MD5 hash of the ordered list of symbols, separated by commas, is calculated. |
There was a problem hiding this comment.
Is this in the order that they are listed in the binary?
There was a problem hiding this comment.
This is not specified in the original description of imphash (irritatingly), but is shown in the reference implementation. Yes, it is in appearance order in the binary without additional lexical ordering. Given that I find it irritating that it's not mentioned in imphash, I'll add that detail here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put an explicit description of the Go symbol hash algorithm in the godoc and in the README.
For elastic/ecs#2083
Please take a look.