Skip to content
This repository has been archived by the owner on May 24, 2023. It is now read-only.

Commit

Permalink
No longer validate ES_HOME in ValidateArgumentsTask
Browse files Browse the repository at this point in the history
We validate the presense of `ES_HOME` but no prior installation to
prevent folks from upgrading from a zip distribution.

We only did this validation on the first custom action as later on we
ourselves set ES_HOME during the installation.

Setting the es var is part of the wxs declaration though and does not
happen as part of a custom action.

When we built and tested this against 6.3.2 our automated testing was
all green. Now using the 6.4.0 snapshot build a vanilla install fails.

This PR removes the check inside the custom action.

Still need to investigate what causes this difference
  • Loading branch information
Mpdreamz committed Aug 1, 2018
1 parent 61c9332 commit 6f396cb
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace Elastic.InstallerHosts.Elasticsearch.Tasks.Immediate
{
public class ValidateArgumentsTask : ElasticsearchInstallationTaskBase
{
public ValidateArgumentsTask(string[] args, ISession session) : base(args, session, installationInProgress: false) { }
public ValidateArgumentsTask(string[] args, ISession session) : base(args, session) { }

protected override bool ExecuteTask()
{
Expand Down

0 comments on commit 6f396cb

Please sign in to comment.